Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed propagation of apriltag and Eigen headers and libraries. #124

Merged
merged 2 commits into from
Apr 5, 2022

Conversation

remod
Copy link
Contributor

@remod remod commented Apr 5, 2022

When compiling our library which depends on apriltag_ros we have got the following error:

.../catkin_ws/install/include/apriltag_ros/common_functions.h:65:10: fatal error: apriltag.h: No such file or directory
   65 | #include <apriltag.h>
      |          ^~~~~~~~~~~~
compilation terminated.

I think that the apriltag::apriltag target is not propagated correctly.

As catkin does not support modern CMake targets like these, in this MR I suggest a workaround, extracting the "good old" apriltag_INCLUDE_DIRS and apriltag_LIBRARIES and propagate them using the Depends keyword.

Additionally, I fixed the Eigen headers not being properly forwarded either.

Copy link
Collaborator

@wxmerkt wxmerkt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for the fix! Will merge once CI comes back

@wxmerkt wxmerkt merged commit c47bdfc into AprilRobotics:master Apr 5, 2022
@wxmerkt
Copy link
Collaborator

wxmerkt commented Apr 5, 2022

I've created a new release 3.2.1 with this fix

@remod
Copy link
Contributor Author

remod commented Apr 5, 2022

Wow you are fast, thank you! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants