install headers consistently in subfolder, install apriltags2_ros targets too #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this patch catkin will set the correct include folder for devel workspaces only (apriltags2_ros/apriltags2/include/); using the package with an install workspace fails. The CMakeLists.txt installs the package headers to .../include/apriltags2/ (this is a good official location to install to because without the subfolder folder the individual headers would clutter .../include). But catkin automatically includes only .../include when the installed package is find_packaged. With this change the official way to include the headers from the apriltags2 package becomes `#include <apriltags2/apriltag.h>` which is consistent between devel and install workspace.
|
this will have a minor conflict with #12 |
|
Ping. We just hit this bug again in preparation for a competition. |
v4hn
changed the title
wxmerkt
added a commit
to wxmerkt/apriltags2_ros
that referenced
this pull request
Mar 7, 2019
- Replace catkin wrapper which had install issues (cf. AprilRobotics#22, AprilRobotics#37) with a submodule of the latest 0.10.0 version of AprilTag3 with CMake/package.xml support - Remove forced build in Debug - this slowed things down. - Removed tag families and options that are no longer supported in v3.0
wxmerkt
added a commit
to wxmerkt/apriltags2_ros
that referenced
this pull request
Mar 7, 2019
- Incorporates and resolves AprilRobotics#37, AprilRobotics#22, AprilRobotics#42, AprilRobotics#36
wxmerkt
added a commit
to wxmerkt/apriltags2_ros
that referenced
this pull request
Mar 7, 2019
- Replace catkin wrapper which had install issues (cf. AprilRobotics#22, AprilRobotics#37) with a submodule of the latest 0.10.0 version of AprilTag3 with CMake/package.xml support - Remove forced build in Debug - this slowed things down. - Removed tag families and options that are no longer supported in v3.0
wxmerkt
added a commit
to wxmerkt/apriltags2_ros
that referenced
this pull request
Mar 7, 2019
- Incorporates and resolves AprilRobotics#37, AprilRobotics#22, AprilRobotics#42, AprilRobotics#36
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this patch catkin will set the correct include folder for devel workspaces only (apriltags2_ros/apriltags2/include/);
using the package with an install workspace fails.
The CMakeLists.txt installs the package headers to .../include/apriltags2/ (this is a good official location
to install to because without the subfolder folder the individual headers would clutter .../include).
But catkin automatically includes only .../include when the installed package is find_packaged.
With this change the official way to include the headers from the apriltags2 package becomes
#include <apriltags2/apriltag.h>which is consistent between devel and install workspace.