-
Notifications
You must be signed in to change notification settings - Fork 763
/
xss_event.rb
165 lines (140 loc) · 5.86 KB
/
xss_event.rb
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
=begin
Copyright 2010-2014 Tasos Laskos <tasos.laskos@arachni-scanner.com>
This file is part of the Arachni Framework project and is subject to
redistribution and commercial restrictions. Please see the Arachni Framework
web site for more information on licensing and terms of use.
=end
# It injects a string and checks if it appears inside an event attribute of any HTML tag.
#
# @author Tasos "Zapotek" Laskos <tasos.laskos@arachni-scanner.com>
#
# @version 0.1.5
#
# @see http://cwe.mitre.org/data/definitions/79.html
# @see http://ha.ckers.org/xss.html
# @see http://secunia.com/advisories/9716/
class Arachni::Checks::XssEvent < Arachni::Check::Base
EVENT_ATTRS = [
'onload',
'onunload',
'onblur',
'onchange',
'onfocus',
'onreset',
'onselect',
'onsubmit',
'onabort',
'onkeydown',
'onkeypress',
'onkeyup',
'onclick',
'ondblclick',
'onmousedown',
'onmousemove',
'onmouseout',
'onmouseover',
'onmouseup',
# Not an event attribute so it gets special treatment by being checked
# for a "script:" prefix.
'src'
]
def self.strings
@strings ||= [
";arachni_xss_in_element_event=#{random_seed}//",
"\";arachni_xss_in_element_event=#{random_seed}//",
"';arachni_xss_in_element_event=#{random_seed}//"
].map { |s| [ "script:#{s}", s ] }.flatten
end
def self.options
@options ||= { format: [ Format::APPEND ] }
end
def run
audit self.class.strings, self.class.options, &method(:check_and_log)
end
def check_and_log( response, element )
body = response.body.downcase
return if element.seed.to_s.empty? || !body.include?( element.seed )
doc = Nokogiri::HTML( body )
seed = element.seed.dup
EVENT_ATTRS.each do |attribute|
doc.xpath( "//*[@#{attribute}]" ).each do |elem|
value = elem.attributes[attribute].to_s.downcase
seed = seed.split( ':', 2 ).last
if attribute == 'src'
# Javascript cases can be handled more reliably by the
# xss_script_context check. However VBScript doesn't have
# full support so we settle.
if value =~ /^(vb|)script:/ && value.include?( seed )
return log vector: element, response: response
end
elsif value.include?( seed )
return log vector: element, response: response
end
end
end
end
def self.info
{
name: 'XSS in HTML element event attribute',
description: %q{Cross-Site Scripting in event tag of HTML element.},
elements: [Element::Form, Element::Link, Element::Cookie, Element::Header],
author: 'Tasos "Zapotek" Laskos <tasos.laskos@arachni-scanner.com> ',
version: '0.1.5',
issue: {
name: %q{Cross-Site Scripting (XSS) in event tag of HTML element},
description: %q{
Client-side scripts are used extensively by modern web applications.
They perform from simple functions (such as the formatting of text) up to full
manipulation of client-side data and Operating System interaction.
Cross Site Scripting (XSS) allows clients to inject scripts into a request and
have the server return the script to the client in the response. This occurs
because the application is taking untrusted data (in this example, from the client)
and reusing it without performing any validation or sanitisation.
If the injected script is returned immediately this is known as reflected XSS.
If the injected script is stored by the server and returned to any client visiting
the affected page, then this is known as persistent XSS (also stored XSS).
Arachni has discovered that it is possible to insert script content directly into
an HTML event attribute. For example `<div onmouseover="x=INJECTION_HERE"</div>`,
where `INJECTION_HERE` represents the location where the Arachni payload was detected.
},
references: {
'ha.ckers' => 'http://ha.ckers.org/xss.html',
'Secunia' => 'http://secunia.com/advisories/9716/',
'WASC' => 'http://projects.webappsec.org/w/page/13246920/Cross%20Site%20Scripting',
'OWASP' => 'www.owasp.org/index.php/XSS_%28Cross_Site_Scripting%29_Prevention_Cheat_Sheet'
},
tags: %w(xss event injection dom attribute),
cwe: 79,
severity: Severity::HIGH,
remedy_guidance: %q{
To remedy XSS vulnerabilities, it is important to never use untrusted or unfiltered
data within the code of a HTML page.
Untrusted data can originate not only form the client but potentially a third
party or previously uploaded file etc.
Filtering of untrusted data typically involves converting special characters to
their HTML entity encoded counterparts (however, other methods do exist, see references).
These special characters include:
* `&`
* `<`
* `>`
* `"`
* `'`
* `/`
An example of HTML entity encoding is converting `<` to `<`.
Although it is possible to filter untrusted input, there are five locations
within an HTML page where untrusted input (even if it has been filtered) should
never be placed:
1. Directly in a script.
2. Inside an HTML comment.
3. In an attribute name.
4. In a tag name.
5. Directly in CSS.
Each of these locations have their own form of escaping and filtering.
_Because many browsers attempt to implement XSS protection, any manual verification
of this finding should be conducted using multiple different browsers and browser
versions._
}
}
}
end
end