Default implementation for revealInParent to reduce boilerplate #33
Conversation
…is default implementation
…ault implementation of revealInParent
…ull before the switch
|
👍 lgtm |
|
Wow, thanks for the commits. I'm checking it out. :) |
| * RootPopup will fire a {@link RevealRootPopupContentEvent}. | ||
| */ | ||
| public enum RevealType { | ||
| Root, |
There was a problem hiding this comment.
Would it be possible to also put the docs over the enum? Its handy for hovering over and seeing what the docs are for it in eclipse at least .Not sure how IDEA would do. Thoughts?
/**
* Root will fire a {@link RevealRootContentEvent}.
*/
Root, There was a problem hiding this comment.
Do we keep only the title above the enum "The RevealType define..." and inline all descriptions?
|
Do you think there should be some test cases? |
|
Since this looks new, I wonder if an example of new use could be done in example or docs? Thoughts? |
|
I see I haven't made it there yet. Thanks :) I'm working my way backwards. |
|
Do you know if all the tests pass? mvn integration-test Can you catch the branch up before tests :) |
|
I just got an error on the constructor of TabContainerPresenter in gwtp-sample-tab. I'll look into this first thing in the morning. I might have to change the new constructor a little bit to make it up for the Object parameter that seem to be called by error. |
|
I had errors in there to, but should be fixed. The widgets have to be provided at the moment, and its possible there is something left over from what I was doing or its not caught up. |
|
The ginbinder fix has been pushed to little later, meanwhile the widgets I changed to provided. Anyway, let me know I can fix that too. |
Update the samples to reflect the changes in the Presenter
Updated the tests to reflect changes in the presenter
Default implementation for revealInParent to reduce boilerplate
Default implementation for revealInParent to reduce boilerplate
Default implementation for revealInParent to reduce boilerplate Former-commit-id: 3f64b4a
I've created a default implementation to the revealInParent() method of the Presenter in relation to this issue on Google Code
Issue 194: Allowing more flexibility and removing some boiler plate when assigning the default slot
https://code.google.com/p/gwt-platform/issues/detail?id=194&colspec=ID%20Stars%20Type%20Status%20Priority%20Component%20Milestone%20Owner%20Summary