Add authentication example

[rolson]

Add authentication example

swift 2034

[dfeinzimer]

I'm still researching why, but the new sample project isn't finding the toolkit package for some reason.

See below

[mhdostal]

Some general usability stuff:

• on iPad Pro 9.7, iOS 15.5 simulator in Portrait mode, the app started up with the < Back button visible. You need to tap that to get back to the view with the "Sign In" button.
• It would match AGOL if the profile pic was a circle:

LoadableImageView(loadableImage: thumbnail)
    .frame(width: 100, height: 100, alignment: .center)
    .clipShape(Circle())

• The first time opening the app and signing in, the "Feature Maps" view appears without it's title and without the "user" icon. Opening a map and going back causes those items to appear.
  

[rolson]

The first time opening the app and signing in, the "Feature Maps" view appears without it's title and without the "user" icon. Opening a map and going back causes those items to appear.

Is that consistent for you? I haven't seen that with Xcode 13.4 and iOS 15.5 simulator (iPhone 13 Pro). What is your config?

[rolson]

@mhdostal thank you for reporting the bugs. I think they should be fixed now

[mhdostal]

Is that consistent for you? I haven't seen that with Xcode 13.4 and iOS 15.5 simulator (iPhone 13 Pro). What is your config?

Xcode 14 beta 2, iPad Pro 9.7 iOS 15.5 simulator. Same behavior with iPhone 13 mini, iOS 16 simulator.

[rolson]

maybe it's a bug in the Xcode beta.

[mhdostal]

maybe it's a bug in the Xcode beta.

I don't see it in your latest bit of code, so it looks like it's OK.

[mhdostal]

With the latest code, I'm seeing this in the log:

=== AttributeGraph: cycle detected through attribute 103752 ===
=== AttributeGraph: cycle detected through attribute 103752 ===
=== AttributeGraph: cycle detected through attribute 104216 ===
=== AttributeGraph: cycle detected through attribute 104216 ===
=== AttributeGraph: cycle detected through attribute 103752 ===
=== AttributeGraph: cycle detected through attribute 103752 ===
=== AttributeGraph: cycle detected through attribute 103752 ===
=== AttributeGraph: cycle detected through attribute 104216 ===
=== AttributeGraph: cycle detected through attribute 104216 ===
=== AttributeGraph: cycle detected through attribute 103752 ===
2022-07-27 13:12:59.104218-0500 AuthenticationExample[10764:47490343] [SwiftUI] Modifying state during view update, this will cause undefined behavior.

When I tap the "Cancel" button when signing in. iOS 15.5, iPad Pro 9.7" simulator; Xcode 14 beta 2.

[rolson]

Modifying state during view update, this will cause undefined behavior.

Anybody know how to set a breakpoint to break on this?

[rolson]

With the latest code, I'm seeing this in the log:

=== AttributeGraph: cycle detected through attribute 103752 ===
=== AttributeGraph: cycle detected through attribute 103752 ===
=== AttributeGraph: cycle detected through attribute 104216 ===
=== AttributeGraph: cycle detected through attribute 104216 ===
=== AttributeGraph: cycle detected through attribute 103752 ===
=== AttributeGraph: cycle detected through attribute 103752 ===
=== AttributeGraph: cycle detected through attribute 103752 ===
=== AttributeGraph: cycle detected through attribute 104216 ===
=== AttributeGraph: cycle detected through attribute 104216 ===
=== AttributeGraph: cycle detected through attribute 103752 ===
2022-07-27 13:12:59.104218-0500 AuthenticationExample[10764:47490343] [SwiftUI] Modifying state during view update, this will cause undefined behavior.

When I tap the "Cancel" button when signing in. iOS 15.5, iPad Pro 9.7" simulator; Xcode 14 beta 2.

its this offending code:

            .toolbar {
                ToolbarItem(placement: .navigationBarTrailing) {
                    Button {
                        showProfile = true
                    } label: {
                        Image(systemName: "person.circle")
                    }
                }
            }

It's the .toolbar that causes the issue, even if I comment it all out all the code inside it I still get the issue:

            .toolbar {
//                ToolbarItem(placement: .navigationBarTrailing) {
//                    Button {
//                        showProfile = true
//                    } label: {
//                        Image(systemName: "person.circle")
//                    }
//                }
            }

However, commenting out the .toolbar{ } causes the issue to go away.

[mhdostal]

However, commenting out the .toolbar{ } causes the issue to go away.

So some odd internal SwiftUI thing. I'm not concerned about it then.

[rolson]

created an issue: #104

[dfeinzimer]

Just the one suggestion.

Also, is there a good set of test credentials to test this with? I used my own for now but I don't have any items in my account.

[dfeinzimer]

For some reason the sign out button doesn't work on the Xcode 14 beta simulators but it's fine on the Xcode 13 ones.

[rolson]

@mhdostal - I just need your re-approval please sir.