Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functions to plot the output of sourmash compare #9

Merged
merged 13 commits into from
Oct 13, 2022

Conversation

taylorreiter
Copy link
Member

@taylorreiter taylorreiter commented Oct 7, 2022

This PR adds default plots for the output of sourmash compare. See this notebook for what I was trying to build toward: https://github.com/Arcadia-Science/2022-prjna853785-sourmash/blob/main/notebooks/20220812-visualize-sourmash-compare-results.ipynb

All of the *Rd and NAMESPACE files are generated automatically using the document() command. The changes to DESCRIPTION were created using use_package().

All tests are passing locally.

Currently the function plot_compare_heatmap doesn't have any tests. I didn't feel like trying to do something clever but probably brittle with capturing the image output. I feel not horrible about this given that the sourmash plot command didn't have tests for a long time.

@taylorreiter taylorreiter marked this pull request as draft October 7, 2022 17:27
@taylorreiter taylorreiter marked this pull request as ready for review October 12, 2022 20:17
Copy link
Member

@elizabethmcd elizabethmcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@taylorreiter taylorreiter merged commit 488dff5 into main Oct 13, 2022
@taylorreiter taylorreiter deleted the ter/plot_compare branch October 13, 2022 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants