Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ geography request ] - IHO Seas #5155

Closed
dustymc opened this issue Oct 12, 2022 · 6 comments
Closed

[ geography request ] - IHO Seas #5155

dustymc opened this issue Oct 12, 2022 · 6 comments

Comments

@dustymc
Copy link
Contributor

dustymc commented Oct 12, 2022

First Step: Explain what geography needs created.

All IHO Seas which can't be recovered from existing Arctos data

@dustymc
Copy link
Contributor Author

dustymc commented Oct 12, 2022

iho_seas.csv

@dustymc dustymc closed this as completed Oct 12, 2022
@sharpphyl
Copy link

Glad to see these added. Some seas (Red Sea/Baltic Sea/Flores Sea) and gulfs are in the Ocean/Continent column. Does that matter with the new structure?

@sharpphyl sharpphyl reopened this Oct 12, 2022
@dustymc dustymc added this to the Needs Discussion milestone Oct 12, 2022
@dustymc
Copy link
Contributor Author

dustymc commented Oct 12, 2022

Does that matter with the new structure?

I don't think so. I tried to add the next thing up, whatever it might be, in the 'next thing up' field, continent-ocean, when there was some logical 'parent.' I didn't do that when there isn't a 'parent' or when there are multiples. I think that will make things more clear and not add confusion now that we have a defined and finite scope (#5138).

I could easily be convinced that what I've done is confusing and/or clutter and these things can stand by themselves, which is more consistent with the source data.

@sharpphyl
Copy link

So, is this basically just the addition of spatial data for existing geographies or are you adding some geographies as well?

For example, Gulf of Aqaba is in the list in the Red Sea. In the past our records just had the Gulf of Aqaba as a specific locality and not in Seas or other higher geography. Having it either way is fine (I like it in the higher geography, of course) as long as we know how to search for localities using it and other in the IHO list.

@dustymc
Copy link
Contributor Author

dustymc commented Oct 12, 2022

I added the stuff in the spreadsheet, all IHO Seas should now be in Arctos and have spatial data. (Some will be near duplicates of other stuff, but if there was any doubt I went ahead and made them so there will be a migration path - #5144) So a bit of both, but the result should be a complete dataset.

how to search

See #5138 - at some level it doesn't matter what you assert (as long as it's not just wrong), geography is being calculated from locality so stuff should be findable (if there's a georeference, of course). But, consistent data is always nice, I'm happy to help move things around if there's a better fit with the current data.

For picking, all of these will contain spatial data source iho_world_seas in remarks, and anything which doesn't contain either that or spatial data source GADM (or any new source that we might agree to) will go away in some way (being deleted or being marked as a 'fun flexible feature') soon-ish. IHO should be complete, GADM is just getting started - I'm sure there will be bumps as I clean things up (perhaps after you've chosen then in data entry but before you've loaded), but I'll do whatever I can to make that as smooth as possible.

@sharpphyl
Copy link

sharpphyl commented Oct 12, 2022

Thanks for the clarification. It all sounds very workable, but we'll speak up if it gets confusing or we need your help to tidy up any of our records.

It's fine to reclose this unless you think it needs more discussion.

@dustymc dustymc closed this as completed Oct 12, 2022
Jegelewicz added a commit to ArctosDB/documentation-wiki that referenced this issue Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants