Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autoload_loan_item bug #51

Closed
dustymc opened this issue Sep 10, 2024 · 14 comments
Closed

autoload_loan_item bug #51

dustymc opened this issue Sep 10, 2024 · 14 comments
Milestone

Comments

@dustymc
Copy link
Contributor

dustymc commented Sep 10, 2024

Source

error logs

Summary

something is wonky

User Interface Changes

none

Data Structure Changes

none

@dustymc dustymc added this to the active milestone Sep 10, 2024
@campmlc
Copy link

campmlc commented Sep 10, 2024

Oh good, I was just going to file an issue. I have items in the loader for a loan that needs to go out today, and they haven't loaded since last night.

@campmlc
Copy link

campmlc commented Sep 10, 2024

Is this working yet? I need to bulkload 104 samples for shipment going out today?

@campmlc
Copy link

campmlc commented Sep 10, 2024

Help please - seriously impeding work. @dustymc @mkoo

@campmlc
Copy link

campmlc commented Sep 11, 2024

ETA on fix? Please, I am working with multiple loans covering several hundred samples over the next two weeks. If this will be a lengthy delay, I need to know and need to let researchers know asap that we have to put loan shipments on hold.

@dustymc dustymc modified the milestones: active, pre-release Sep 11, 2024
@mkoo
Copy link
Member

mkoo commented Sep 11, 2024

This is in progress and was slightly delayed yesterday by TACC resource challenges (we had no dev environment) -- sorry for the lack of details (that was my fault and crossed wires of communication) but in progress

@dustymc dustymc closed this as completed Sep 12, 2024
@campmlc
Copy link

campmlc commented Sep 12, 2024

Reopening - the tool is duplicating loan items, adding 2, 3, or 4 copies of each requested item.
Here is a loan item bulkload file I loaded to the component loader, and then downloaded as csv to document what was actually inputed and marked to autoload:
bulkloadLoanItemData (14).csv

Here is the output - the list of items in the loan:
LoanItemDownload - 2024-09-11T205847.434.csv

I've tested this 4 times now by deleting all items in the loan, checking and reloading the input file to make sure there are only 63 items being loaded, but 221 items in the loan.

@dustymc dustymc modified the milestones: pre-release, active Sep 12, 2024
@dustymc dustymc reopened this Sep 12, 2024
@dustymc
Copy link
Contributor Author

dustymc commented Sep 13, 2024

@campmlc I have a temp test DB now and I can't replicate this, I can't see any way the code could have done this, and the duplicate parts don't seem to exist so I can't see how they were created.

Not all of the barcodes have parts associated at test so I'm not seeing exactly what happened, but 33 of them loaded as requested.

I'm hesitant to turn this back on without some idea of how what you're reporting might have happened. (But it seems it was easy to un-do, so call it gremlins and rock on??)

The only thing that I can imagine is that you loaded the CSV multiple times - a part can be subsampled any number of times, and any number of those subsamples could be added to a loan - but that's nothing more than speculation, I can't find any evidence of anything at all.

Can you try to do whatever you did at https://web.corral.tacc.utexas.edu:9013/ please?

If your results in test match mine, can I try to manually run your bulkloadLoanItemData (14).csv file at production?

@campmlc
Copy link

campmlc commented Sep 13, 2024

Yes, it is very strange. I had marked the samples to load multiple times in the component loader when it was stuck. Yet I only ever saw 63 samples on autoload. After you unstuck it and the samples loaded, I saw over 200 samples in the loan, which I figured were the result of my loading it multiple times. The odd thing was that not all the samples had the same number of duplicates (most 4, but some 3 or 2).
So the first thing I did was to delete everything from the loan, wait until the loan items read "0" in the loan form, and then rebulkload. Each time I did this, there were 63 items marked as autoload in the component loader, and each time there were 221 in the final loan list. Each time, I deleted the items from the loan, and started over, with the same result. Note that there were actually two loans I did this for, with different initial values, but both ended up with multiple duplicate samples (I only shared the file for the first). Eddie's in the Time Space Continuum?
I'll try with the link and let you know.

@campmlc
Copy link

campmlc commented Sep 13, 2024

@dustymc I've loaded the file to the dev box above. Nothing is happening, so not sure how long it will take to load?
In the meantime, please go ahead and load the file to production.

@campmlc
Copy link

campmlc commented Sep 13, 2024

FWIW I've rebooted my computer, in case this was some corrupted Excel-generated csv file.

@dustymc
Copy link
Contributor Author

dustymc commented Sep 13, 2024

That version of test is a little fragile and I don't have time to deal with it now, so...

load the file to production.

Screenshot 2024-09-13 at 13 37 10 Screenshot 2024-09-13 at 13 37 47

Seems to have worked, I don't see any extra magical whatevers, please let me know ASAP if I need to disable this thing.

I'm happy to blame Eddie, close this if you are too....

@campmlc
Copy link

campmlc commented Sep 13, 2024

Worked for me too. Maybe it was csv ghosts from my Excel left open too long . . .Thanks!

@campmlc
Copy link

campmlc commented Sep 13, 2024

I can't close, but OK to close.

@mkoo
Copy link
Member

mkoo commented Sep 13, 2024

Fun to see mysterious resolution! at least original bug is squashed- thx all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants