Skip to content

Commit

Permalink
FEATURE: disable parameter upload if no FC is connected
Browse files Browse the repository at this point in the history
  • Loading branch information
amilcarlucas committed Jun 7, 2024
1 parent 4aa528b commit a91a5c1
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 4 deletions.
1 change: 1 addition & 0 deletions MethodicConfigurator/frontend_tkinter_parameter_editor.py
Original file line number Diff line number Diff line change
Expand Up @@ -271,6 +271,7 @@ def __create_parameter_area_widgets(self):
# Create upload button
upload_selected_button = tk.Button(buttons_frame, text="Upload selected params to FC, and advance to next param file",
command=self.on_upload_selected_click)
upload_selected_button.configure(state='normal' if self.flight_controller.master else 'disabled')
upload_selected_button.pack(side=tk.LEFT, padx=(8, 8)) # Add padding on both sides of the upload selected button
show_tooltip(upload_selected_button, "Upload selected parameters to the flight controller and advance to the next "
"intermediate parameter file\nIf changes have been made to the current file it will ask if you want "
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ def __update_table(self, params, fc_parameters):
column.append(self.__create_flightcontroller_value(fc_parameters, param_name, param_default, doc_tooltip))
column.append(self.__create_new_value_entry(param_name, param, param_metadata, param_default, doc_tooltip))
column.append(self.__create_unit_label(param_metadata))
column.append(self.__create_upload_checkbutton(param_name))
column.append(self.__create_upload_checkbutton(param_name, bool(fc_parameters)))
column.append(self.__create_change_reason_entry(param_name, param, column[3]))

column[0].grid(row=i, column=0, sticky="w", padx=0)
Expand Down Expand Up @@ -316,9 +316,10 @@ def __create_unit_label(self, param_metadata):
show_tooltip(unit_label, unit_tooltip)
return unit_label

def __create_upload_checkbutton(self, param_name):
self.upload_checkbutton_var[param_name] = tk.BooleanVar(value=True) # Default to selected
upload_checkbutton = ttk.Checkbutton(self.view_port, variable=self.upload_checkbutton_var[param_name])
def __create_upload_checkbutton(self, param_name, fc_connected):
self.upload_checkbutton_var[param_name] = tk.BooleanVar(value=fc_connected)
upload_checkbutton = tk.Checkbutton(self.view_port, variable=self.upload_checkbutton_var[param_name])
upload_checkbutton.configure(state='normal' if fc_connected else 'disabled')
show_tooltip(upload_checkbutton, f'When selected upload {param_name} new value to the flight controller')
return upload_checkbutton

Expand Down

0 comments on commit a91a5c1

Please sign in to comment.