Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support sending SET_GPS_GLOBAL_ORIGIN message for Copter and Rover (at least) #1702

Closed
rmackay9 opened this issue Dec 11, 2017 · 3 comments
Closed

Comments

@rmackay9
Copy link
Contributor

In Copter-3.5.4 and Rover-3.2-rc3 (and higher) if the user wishes to use non-GPS navigation (i.e. the Pozyx system, visual odometry, etc) then the EKF must be told where the EKF origin should be placed using the SET_GPS_GLOBAL_ORIGIN message (http://mavlink.org/messages/common#SET_GPS_GLOBAL_ORIGIN). We should add a new option to the right-mouse-button menu called "Set EKF Origin Here". This will be a very rarely used message but I don't think we should hide it on the Ctrl-F menu.

By the way, in older versions of the vehicle firmware we used the SET_HOME_POSITION message (http://mavlink.org/messages/common#SET_HOME_POSITION) to set the EKF origin but this led to some issues with callers accidentally setting the EKF origin when they really only wanted to set home.

We need this message for both Copter and Rover.

@meee1
Copy link
Contributor

meee1 commented Dec 11, 2017

I assume this message is guarded on copter/rover side to prevent crashing?

meee1 added a commit that referenced this issue Dec 11, 2017
@meee1
Copy link
Contributor

meee1 commented Dec 12, 2017

currently MP implemented no safeguards around this. I could check for if armed?

@meee1 meee1 closed this as completed Dec 12, 2017
@rmackay9
Copy link
Contributor Author

Thanks!

@meee1, I don't think it should be necessary to check anything on the MP side. In ardupilot we check the message to make sure it's a valid lat/lon/alt. Also we only accept setting the origin once and most users will want to set it before arming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants