Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plan: Fence Radius truncated to integer #2631

Closed
rmackay9 opened this issue Jun 1, 2021 · 3 comments
Closed

Plan: Fence Radius truncated to integer #2631

rmackay9 opened this issue Jun 1, 2021 · 3 comments
Labels

Comments

@rmackay9
Copy link
Contributor

rmackay9 commented Jun 1, 2021

The Plan screen's Fence list has a "Radius" parameter which accepts floating point numbers but seems to truncate them to integers. The issue can be reproduced by doing this:

  • Open MP and start the Simulator (Rover or Copter)
  • Open the Plan screen and select FENCE from the drop-down on the top right
  • Click on the map in a few places to create FENCE_CIRCLE_EXCLUSION fences (BTW, I think these string could be made more readable by changing to "Circle Exclusion" but I think I've already raised another issue about this)
  • Change a radius to "3.5" and press "Write"
  • Push the "Read" button to read back the fences and note that "3.5" has been changed "3".

image

I suspect that MP is changing this field to an integer because it is normally used for the "p1" parameter of commands which is always and integer. From what I can see the MAV_CMD_NAV_FENCE_CIRCLE_EXCLUSION message accepts floating points but please tell me if I'm wrong.

@rmackay9 rmackay9 added the bug label Jun 1, 2021
@meee1
Copy link
Contributor

meee1 commented Jun 1, 2021

i believe this is AP dropping the decimals

@meee1
Copy link
Contributor

meee1 commented Jun 1, 2021

image

@peterbarker
Copy link
Contributor

Found the bug. It's in ArduPilot. Closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants