Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added checkbox "Skip Download" #2565

Merged
merged 1 commit into from Feb 27, 2021
Merged

Added checkbox "Skip Download" #2565

merged 1 commit into from Feb 27, 2021

Conversation

roberthudson
Copy link
Contributor

As per Tridge's request to skip downloading of SITL binaries

#2518

(also adjusted tab order of controls)

@AppVeyorBot
Copy link

@tridge
Copy link
Contributor

tridge commented Feb 27, 2021

I've tested this and it works nicely. It looks like this:
image
if the SITL binary doesn't exist you get a popup saying that it failed to download

@roberthudson
Copy link
Contributor Author

I wasn't sure where to put the checkbox.

Placing it to the right of "Wipe" would mean widening the control. That might have negative consequences on narrower screens.

Feel free to adjust as you see fit.

@roberthudson
Copy link
Contributor Author

Instead of a checkbox, would it be better to simply skip downloading if the binary already exists?

Or is it important to download the latest version? How often do the binaries change?

Sorry for the questions, I'm new here :-)

@tridge
Copy link
Contributor

tridge commented Feb 27, 2021

Or is it important to download the latest version? How often do the binaries change?

they change whenever ArduPilot master changes, which is often several times in a day. We usually do want the latest build, but in the future we might like an option to download one of the stable builds.

@meee1 meee1 merged commit 7df642b into ArduPilot:master Feb 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants