GCSViews: If the delay of WAYPOINT is set to less than 0, set it to 0 #2654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Build MissionPlanner 1.0.2784 completed (commit af389bec04 by @muramura) |
meee1
requested changes
Aug 20, 2021
muramura
force-pushed
the
MP_If_the_delay_of_WAYPOINT_is_set_to_less_than_0_set_it_to_0
branch
from
ad3bd87
to
63025a4
Compare
|
✅ Build MissionPlanner 1.0.2883 completed (commit 2af022d25f by @muramura) |
This reverts commit 17f43ba.
|
✅ Build MissionPlanner 1.0.2884 completed (commit 6b24180976 by @muramura) |
|
I committed again, to undo the mono commit. |
|
The reworked PR is up and closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I set it to 0 if the WAYPOINT delay is set to a value less than 0.
I set the PR to return an error response if the WAYPOINT delay is set to a value less than 0 on the ArduPilot side.
I hoped that the ArduPilot members would check the input value on the GCS side.
I was unable to set a value less than 0 for the WAYPOINT delay in APM PLANNER2.
I decided to change the MP side.
ArduPilot/ardupilot#17704