GCSViews: If the delay of WAYPOINT is set to less than 0, set it to 0 #2679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Build MissionPlanner 1.0.2885 completed (commit c6feda5c20 by @muramura) |
meee1
reviewed
Sep 16, 2021
| @@ -2979,7 +2979,16 @@ private Locationwp DataViewtoLocationwp(int a) | |||
| false); | |||
| } | |||
|
|
|||
| temp.p1 = float.Parse(Commands.Rows[a].Cells[Param1.Index].Value.ToString()); | |||
There was a problem hiding this comment.
this appears to break everything if its not a waypoint
There was a problem hiding this comment.
@meee1 san.
I've changed it.
I checked the file to see that parameter 1 of the other command was set.
save Waypoints file
QGC WPL 110
0 1 0 16 0 0 0 0 40.453949 141.541901 56.040001 1
1 0 3 16 0.00000000 0.00000000 0.00000000 0.00000000 40.45522560 141.54160740 100.000000 1
2 0 3 93 -1.00000000 0.00000000 0.00000000 0.00000000 40.45586230 141.54049160 100.000000 1
muramura
force-pushed
the
mp_MP_If_the_delay_of_WAYPOINT_is_set_to_less_than_0_set_it_to_0-2
branch
from
f17dba0
to
836af1e
Compare
|
✅ Build MissionPlanner 1.0.2956 completed (commit d4145bbcc7 by @muramura) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworked #2654.