Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rover: Sail 3 position switch should disable motors not inhbit forward thrust. #19352

Open
geofrancis opened this issue Nov 23, 2021 · 0 comments

Comments

@geofrancis
Copy link

geofrancis commented Nov 23, 2021

I have been testing the sailing code with different motor configurations and I have found that the 3 position motorsail switch only inhibits forward propulsion, it doesn't disable the motors. This becomes a problem when its used in an omni configuration or a twin screw configuration as even in sail only mode its trying to use the bow and stern thrusters for yaw control and its trying to use the left and right main motors for yaw by running them in opposite directions.

there should be a bitmask for disabling motors when sailing so that the propellers arent turning at all when sailing unless in motor or motor assist mode or ideally 2 bit masks, one for motor only and one for motor assist. that way thrusters can be limited to motor only mode.

The main reason I am using this mode switch is to conserve battery power but that won't work if it's constantly running thrusters and main motors.

@IamPete1 IamPete1 changed the title Sail 3 position switch should disable motors not inhbit forward thrust. Rover: Sail 3 position switch should disable motors not inhbit forward thrust. Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants