Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sub: Add support for TSYS01 on pixhawk 2 #9800

Closed
patrickelectric opened this issue Nov 15, 2018 · 2 comments · Fixed by #12428
Closed

Sub: Add support for TSYS01 on pixhawk 2 #9800

patrickelectric opened this issue Nov 15, 2018 · 2 comments · Fixed by #12428
Labels
Milestone

Comments

@patrickelectric
Copy link
Member

Moved from: bluerobotics/ardusub#97
Original author: @jaxxzer

Feature request

The bus is hard coded, it needs to be determined at run time.

Platform
[ ] All
[ ] AntennaTracker
[ ] Copter
[ ] Plane
[ ] Rover
[x] Submarine

@IamPete1 IamPete1 added the Sub label Nov 17, 2018
@jaxxzer jaxxzer added this to the Sub-3.6.0 milestone Jul 9, 2019
@jaxxzer
Copy link
Member

jaxxzer commented Sep 12, 2019

The problem is the i2c bus to scan/probe is hardcoded to 1 here:

_dev = std::move(hal.i2c_mgr->get_device(1, TSYS01_ADDR));

We can update init() with a bus number parameter, and configure the bus according to the hardware, similar to how we select GND_EXT_BUS in system.cpp.

attention @Williangalvani

@jaxxzer
Copy link
Member

jaxxzer commented Sep 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants