Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix servo reverse related issue. #24

Merged
merged 1 commit into from
Dec 16, 2022

Conversation

41Mo
Copy link
Contributor

@41Mo 41Mo commented Apr 16, 2022

Bug report

Closes #22

Issue details

Platform
[ ] All
[ ] AntennaTracker
[ ] Copter
[ x ] Plane
[ ] Rover
[ ] Submarine

Airframe type

  • Flying wing

Hardware type

  • Gazebo / SITL

Description

  • Servos directions for the zephyr in the ardupilot_plugin parameters are reversed.

Changes

  • Changed multiplier in zephyr sdf
  • Update parameters description zephyr sdf

Test

Tested on zephyr with ardupilot 4.1.7

@41Mo 41Mo changed the title Fix servo reverse related issue. Fix servo reverse related issue #22. Apr 20, 2022
@srmainwaring
Copy link
Collaborator

@41Mo, thank you for the PR - it will be good to get the Zephyr behaviour sync'd up with the current params in SITL.

As of PR #29 Gazebo Garden is now default. I have changed the base branch for this PR to main. Could you please rebase and force push (happy to do this on your behalf if you prefer).

@srmainwaring srmainwaring changed the base branch from ignition-fortress to main December 14, 2022 08:57
@41Mo 41Mo closed this Dec 15, 2022
@41Mo 41Mo reopened this Dec 15, 2022
@41Mo
Copy link
Contributor Author

41Mo commented Dec 15, 2022

@srmainwaring done

@41Mo 41Mo changed the title Fix servo reverse related issue #22. Fix servo reverse related issue. Dec 15, 2022
@srmainwaring srmainwaring merged commit 8f3970a into ArduPilot:main Dec 16, 2022
@srmainwaring
Copy link
Collaborator

LGTM. Confirmed on ardupilot master / Gazebo Sim, version 7.1.0

sim_vehicle.py -v ArduPlane -f gazebo-zephyr --model JSON --map --console
FBWA> arm throttle
FBWA> rc 3 1800
FBWA> circle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zephyr elevon servo inconsistency with ardupilot parameters
2 participants