Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common: add djirs2 gimbal support to upcoming features #4912

Merged
merged 2 commits into from
Jan 30, 2023

Conversation

rmackay9
Copy link
Contributor

@rmackay9 rmackay9 commented Jan 30, 2023

This adds a wiki page to go with the new DJI RS2 gimbal support. ArduPilot/ardupilot#22776

Note that the Siyi A8 support has been released with 4.3 so I've removed it from the upcoming features.

This has been tested on my local machine and looks OK.

@Hwurzburg
Copy link
Contributor

@rmackay9 we need to understand why your local build is not showing the significant wiki build error that this creates when you tested this PR locally...it leaves the SIYI page "floating" (not in a TOCTREE)....it must be linked on the camera and gimbals page in the bottom toctree....

Copy link
Contributor

@Hwurzburg Hwurzburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix toctree build error

@rmackay9
Copy link
Contributor Author

@Hwurzburg,

Txs for the review. I've fixed the missing toc now and I don't see build errors any more.

@Hwurzburg
Copy link
Contributor

thanks...

@Hwurzburg Hwurzburg merged commit 748daeb into ArduPilot:master Jan 30, 2023
@rmackay9 rmackay9 deleted the gimbal-djir2 branch January 30, 2023 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants