Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create common-sonar-L04xMTW-GL04xMT.rst #6053

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

AlksSAV
Copy link
Contributor

@AlksSAV AlksSAV commented Jun 15, 2024

No description provided.

@AlksSAV AlksSAV marked this pull request as ready for review June 15, 2024 11:33
@AlksSAV
Copy link
Contributor Author

AlksSAV commented Jun 15, 2024

Added support for new sonars. More information on the discuss.ardupilot.


Connecting and Configuring
--------------------------
.. image:: ../../../images/Sonars nmea.png
Copy link
Contributor

@Hwurzburg Hwurzburg Jun 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cant have whitespace in filename....also document not in a TOCtree....needs addition on rangefinder landing page TOCtree and squash to one commit

@rmackay9
Copy link
Contributor

Hi, thanks for this. I think it would be easier for users if the driver was written in Lua avoiding the need for the external arduino board but in any case these instructions allow users (with some effort) to use previously unusable underwater sonar

@AlksSAV
Copy link
Contributor Author

AlksSAV commented Jun 16, 2024

@rmackay9! If I succeed, I will try to do it in a LUA script.
@Hwurzburg I changed the name of the image and added it to the list. Could you squash the commit I've tried, I'm having trouble with something.

@Hwurzburg
Copy link
Contributor

you probably needed to rebase on master before trying to squash the 8 commits....I've squashed and pushed back....and will merge once CI passes again (it does locally)

@Hwurzburg Hwurzburg merged commit f128741 into ArduPilot:master Jun 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants