mavparmdiff.py does not catch parameter differences

[WickedShell]

Parameter files from mavparms.py have differences which mavparmdiff.py does not detect. Included a trimmed version of the files. The difference I'm tracking in the uploaded files is ARSPD_OFFSET

parms.zip

[peterbarker]

https://github.com/ArduPilot/pymavlink/blob/master/mavparm.py#L13 <- this is considered to be a volatile value and is explicitly excluded.

[WickedShell]

That's pointlessly bad for a param comparison tool, as it breaks the main usage, detect differences. (In this case for example this offset is actually what I was looking for/expecting)

[peterbarker]

On Sun, 25 Nov 2018, WickedShell wrote: That's pointlessly bad for a param comparison tool, as it breaks the main usage, detect differences. (In this case for example this offset is actually what I was looking for/expecting)

I guess the point is that they're *always* going to be different.... The same code is used within mavproxy, so a simple option to the mavparmdiff.py wouldn't be sufficient to change behaviour everywhere...

[tridge]

I think we should have a command line option to not exclude the volatiles

[WickedShell]

I guess the point is that they're always going to be different....

Not actually true for ARSPD_OFFSET which is why I was looking for it (among others originally).

I think we should have a command line option to not exclude the volatiles

That would work for me.

[peterbarker]

#247

[WickedShell]

This was done awhile ago as an opt in.