Improve to_string and x25crc #748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alehed
force-pushed
the
improve_to_string
branch
3 times, most recently
from
0ee4550
to
fc20dd6
Compare
alehed
force-pushed
the
improve_to_string
branch
from
fc20dd6
to
d56a0b8
Compare
tridge
approved these changes
Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the to_string method (in theory with correct typing it should not be necessary, but I don't want to reason about types before using only python3 with type annotations).
It also improves the type support of the crc computation and removes an instance where the crc computation was copy-pasted.
This PR should fix #716.