Mavgen JS: Add require('buffer') statement to allow JS output to work in React Native #919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @davidbuzz. This is a small tweak that I needed to make the JS work with both React Native and NodeJS. |
|
this looks harmless to me , lets merge it. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am using the Mavlink JS Nextgen output in a React Native project on Android mobile device.
In Node JS, the 'Buffer' object is globally available by default, but in React Native this is not the case.
This PR adds the line:
var Buffer = require('buffer').Buffer;to the generated output.This provides the Buffer object in React Native, and it is benign to also include this line in Node JS.
I have successfully used the updated generator in my React Native project, and checked that it also can be imported successfully in Node. Also, the CI tests the generator output in various versions of Node.