Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React Native support #27

Open
conntsing opened this issue Nov 14, 2016 · 6 comments
Open

React Native support #27

conntsing opened this issue Nov 14, 2016 · 6 comments

Comments

@conntsing
Copy link

conntsing commented Nov 14, 2016

qq 20161114224415

i have a problem when i run this compotent on android

i knows react not enough dasy sorry

@AriTheElk
Copy link
Owner

As of right now, hedron is completely untested with react-native. I would definitely love to add support for it in the future, but I'm unable to do it myself right now.

If you, or any one else wants to step up and get hedron working in react-native, that would be amazing 😸

@AriTheElk AriTheElk changed the title does this can Support react-native React Native support Nov 14, 2016
@AriTheElk AriTheElk added this to the v1.0.0 Release milestone Dec 30, 2016
@AriTheElk
Copy link
Owner

Since react-native now supports percentage based dimensions, porting hedron should be very trivial. I'm hoping that somebody who has more experience than me in react-native can tackle this. I could attempt to add support myself, but I'm not too well versed in react-native, and I definitely want it to be implemented the proper way.

@jim-at-jibba
Copy link
Contributor

@garetmckinley Is this something you (and others) are interested in? I am happy to spend the time porting this over if you think others would be interested.

@AriTheElk
Copy link
Owner

That's totally up to you @jim-at-jibba. Native support would be a welcome addition IMO, but I can't speak for the amount of demand there is for it. If it's something that you'd like to tackle, I'll, of course, accept a PR for it 😸

@jim-at-jibba
Copy link
Contributor

Ok cool. I will have a poke around and see how much work it is. I know i would use it so will probably be worth it. Thanks for merging in my PR

@AriTheElk
Copy link
Owner

No problem, I appreciate the PR 👍 feel free to reach out if you have any questions. Twitter DMs are probably the quickest way to reach me, but I scroll through my GitHub notifications at least once daily.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants