Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GENERAL discussion, feedback, questions belong here! (v14) #417

Closed
Aris-t2 opened this issue Sep 18, 2021 · 212 comments
Closed

GENERAL discussion, feedback, questions belong here! (v14) #417

Aris-t2 opened this issue Sep 18, 2021 · 212 comments

Comments

@Aris-t2
Copy link
Owner

Aris-t2 commented Sep 18, 2021

Make sure you have updated your configuration to the most recent version of this projects files and are using the latest version of the "options" required by your Firefox version >before< reporting problems!

Continued from #3, #41, #88, #109, #133, #163, #189, #211, #241, #273, #308, #368 and #404

Instead of opening new "issues" for general talk we can use this area for discussions, feedback and questions. Open new "issues" for real bugs and problems.

Custom JS scripts to restore more classic features
https://github.com/Aris-t2/CustomJSforFx

Things this project will not target/recreate

  • a CTR like plugin/application to generate ready-to-use CSS
  • curved tabs (thanks those are finally gone!)
  • old complete themes

Things not possible with CSS

  • more toolbars like add-on/status bar (CSS can not create new toolbars)
    • displaying full sized status popup below window content is possible
    • bookmarks toolbar at windows bottom is possible (simulated addon-bar)
  • new buttons (CSS can not create new buttons)
  • additional menuitems (CSS can not create new items)
  • custom/new/different functions for buttons/menuitems/menus
  • activity indicator (see 'custom JS scripts')
  • preference/options window
  • additional location bar
  • favicon in location bars identity box (see 'custom JS scripts')
  • moving menubar items to a different toolbar
  • restart button (see 'custom JS scripts')
  • ... many more
@BoomerangAide
Copy link

BoomerangAide commented Sep 18, 2021

Since we were talking about compact stuff recently, I wanted to share another piece of code from my my_userChrome.css file:

/* Hide lines with something else than the id in login popup */
#PopupAutoComplete richlistbox richlistitem div div :not(.line1-label)  {
	display: none !important;
}

On a site with multiple login, it get rid of that stupidly repeating "From this website" line below each login entry.
Not sure what would make that line say something else, maybe a feature I don't use, but maybe that code could fit somewhere?

Ps: I thought I already shared that, but a search gave nothing. But I wonder if the github search really work that well to begin with. 🤔

@Aris-t2
Copy link
Owner Author

Aris-t2 commented Sep 18, 2021

Never though about removing that line, but its great we can achieve it using CSS.

About the Github search. Once a thread gets too long, entries get hidden and you have to click "Load more..." link to show them again. Search won't find the hidden stuff, so I think this is what happened to your post.

image

@ImSpecial
Copy link

So I've been getting these kind of "popups" since I updated to Firefox 92.0, happens on sites like "Spotify, Apple, Outlook, etc.

https://i.imgur.com/P0mZtC8.png
https://i.imgur.com/KcXuj4d.png

I was wondering if these can be completely hidden and removed from happening, or is this not even CSS stuff anymore?

@EdwardKiefer
Copy link

So I've been getting these kind of "popups" since I updated to Firefox 92.0, happens on sites like "Spotify, Apple, Outlook, etc.

https://i.imgur.com/P0mZtC8.png
https://i.imgur.com/KcXuj4d.png

I was wondering if these can be completely hidden and removed from happening, or is this not even CSS stuff anymore?

Do you use any kind of adblocker like ublock Origin, I would think that would take care of the second one (that seems like spam).
Not sure on the DRM one.

@ImSpecial
Copy link

Yes, uBlock Origin, but these don't seem to be your typical popups like from ads, more like notifications from Firefox. Like when you go and install an "Add-on" and a small pop up will occur, asking to allow or deny.

@ImSpecial
Copy link

FYI, I was able to solve this with two about:config pref's.

DRM popup;
browser.eme.ui.enabled to false

Mailto popup;
network.protocol-handler.external.mailto to false

@BoomerangAide
Copy link

BoomerangAide commented Sep 20, 2021

So I've been getting these kind of "popups" since I updated to Firefox 92.0, happens on sites like "Spotify, Apple, Outlook, etc.

https://i.imgur.com/P0mZtC8.png
https://i.imgur.com/KcXuj4d.png

I was wondering if these can be completely hidden and removed from happening, or is this not even CSS stuff anymore?

Though you already found a solution, yes, it probably could have been hidden by CSS, if those have an id and/or other properties than can be used to target with css (see the id finding part of the readme)
I myself have this:

/* Hide the "update available" popup */
#appMenu-notification-popup {
	display: none !important;
}

To no longer be bothered with Firefox reminders that it can be updated. Though I haven't seen that popup for so long I can't tell for sure if my css is still working, or if the popup was just removed at some point 😛

@bendover22
Copy link

Unless I missed - a lot, does customCSSforFx have any code to change heights of urlbar-container , urlbar-input-container & matching searchbar elements? Some of the code I tried to use as root and / or like the example below.
Since this isn't a feature of CustomCSS (I guess), maybe someone besides Aris could point me in the right direction.

I'm looking mostly to chg the heights of entry field(s) for URL & Search input containers, and the 40px TALL #urlbar-container and #search-container.
Everything "Photon" is turned off AFAIK- nothing expands or jumps out.

Mozilla has set the "--urlbar-container-height: 40.00px" as root & nothing I've found online or thought of myself, has overridden the 40px.
(See screenshot) I was able to chg heights of the INPUT containers (url & search), but NOT the outer 40px container (see screen).

Code below is from Mozilla support. I'm not sure why (cor-el) did some things, like repeat "#urlbar-input-container" in succession, but he is usually right. https://support.mozilla.org/en-US/questions/1284030

#urlbar[breakout],
#urlbar[breakout][breakout-extend] {
  --urlbar-height: 28px !important;
  --urlbar-toolbar-height: 30px !important;

  width: 100% !important;
  top: calc((var(--urlbar-toolbar-height) - var(--urlbar-height)) / 2) !important;
  left: 0 !important;
}

#urlbar[breakout][breakout-extend] > #urlbar-input-container,
#urlbar-input-container {
  height: var(--urlbar-height) !important;
  width: 100% !important;
  padding-block: unset !important;
  padding-inline: unset !important;
  transition: none !important;
}

#urlbar[breakout][breakout-extend] > #urlbar-background {
  box-shadow: 0 1px 4px rgba(0,0,0,.05) !important;
  animation: none !important;
}

Modified April 11, 2020 at 2:11:24 PM PDT by cor-el 

fx-92-nav-bar_urlbar-container-can't chg size

@BoomerangAide
Copy link

@bendover22 : I'm not sure we would be talking about the same thing, but in my case, I had an issue of nav-bar having too much height, causing empty space above and below, and the separators between the url bar and search bar being stretched vertically.
And same experience, css was powerless, so I eventually ended up using my custom js changes file, that work along CustomJSforFx enabled scripts, with the following code:

		///
		/// Change navbar height because too big otherwise
		///
		
		try {
			let nav_bar = document.getElementById("nav-bar");
			nav_bar.setAttribute("height","28px");
		}
		catch(e) { console.log("height setting failed");  console.log(e); }

To recap:

  • the above is NOT CSS
  • I'm interested if CSS ever become able to do something about those components again, but it failed for me
  • Custom javascript may be the solution for you too, but once again, as you're not targeting "nav-bar", maybe we're not talking about the same thing
  • If the only solution is javascript, it may be better to start discussing it on the other project (see link above)

@bendover22
Copy link

bendover22 commented Sep 22, 2021

@BoomerangAide - "What is in a name? Would not a nav-bar by any other name be just...." W.S.
We are talking about the same thing (essentially).
Thanks for the code. Do you have to enable one or ? many files from CustomJSforFx? If so, which one(s)?
Do you then have to comment out certain parts that change things you don't want changed?

Here's what I found to change height of urlbar-container; search-container; and the text entry containers.

:root {
    --urlbar-container-height: 34px !important; }

:root { 
   --urlbar-min-height: XXpx !important; } /*optional*/

#urlbar-container, #search-container {
    padding-block: 1px !important; } /*** This puts 1px padding ABOVE / BELOW the url & search input ***/

Decide what height you want for the urlbar-container ("text entry field") & search-container (the tallest part of this toolbar). URL & Search containers must be same ht., so the toolbar's bottom edge is even .

The magic bullet to override Fx's 40px H urlbar-container (& search-container)is shown.
In my_userChrome.css, "must define" the fixed ht of url & search containers, < 40px:

If you need to change height of URL & Seach bars (input area) from the default (32px for Normal density), you can define it the same way as --urlbar-container-height:

I found I needed to override the Moz value for padding-block:4px; on urlbar-container, search-container, or the url-container extends past the input containers more than I wanted.
Adjust values as desired. Hope there are no errors - working on my desktop.

@Acid-Crash
Copy link

Hi @Aris-t2
Maybe I am mistaken, but some time ago there was a module to change Bookmark folder icon color to the one you like (vial fill css rule).
I tried to find one within the latest files, but the only thing I have found is the complete replacement for the Bookmark icon.

Maybe you can help with the following...
I would like to replace and recolor the new Bookmark folder icon (chrome://global/skin/icons/folder.svg) that appears in the Bookmarks Menubar, Toolbar, and Places/History (basically everywhere it is present)...

I tried to reverse engineer the mentioned module but got a mixed results (messed up Bookmark Gear and tag icons)

Thank you in advance

@bendover22
Copy link

https://github.com/Acid-Crash
Depending on what you want - one color of folder, to use everywhere a typical, small folder icon is used?
Like in Fx 92, the plain "folder" image is just a black outline of a folder shape. No color fill, other than the BG color.

I think what you may want is something like /chrome/css/generalui/bookmark_icons_colorized.css
If you search the customcssforFx package's "userChrome.css" file , you'll find several for "bookmarks" & possibly "folders."

The former has more than just a colored folder icon. If you don't like the color of the folder icons (like yellow), you can backup / save the orig. image under the customcss "image" folder, then either change the color in another drawing or graphic editor app. Then save it to the images folder, using the SAME name as the original. Or find images already colored & put them in the proper path in customcssforFx.

What ever OS you use, get a "text editor" w/ a GOOD search function, that shows results (in partial sentences, for context), the line # where located, etc. You can find what you're looking for MUCH faster.
For Windows, Notepad++ - very popular; (free, open source) was one I used before moving to Linux.
For Linux, there are many. One w/o too steep a learning curve, but still lots of features (& excellent search / find tool) is Geany, that I've used several yrs. Both have good help sites / forums and / or mailing list, where help usually comes quickly.

Regardless, I suggest getting a dark theme for the text editor. Black or V dark background & as bright of syntax coloring as you want (say for CSS files). Much easier to see for search thru a file, or make simple changes, rather than white / nearly white BG. Easier on the eyes.

@Acid-Crash
Copy link

@bendover22

I think what you may want is something like /chrome/css/generalui/bookmark_icons_colorized.css

I know about this module, it replaces every icon within Bookmarks (folder, tag, gear).

I am interested only in replacing the bookmark folder icon (I have the needed SVG file).
As mentioned earlier, I tried to reverse engineer bookmark_icons_colorized.css but did not manage to do it right (tag and gear icon are also become replaced with folder icon)
As for the editing the icon, choosing the text editor, I am aware of this matter.

@silverwings15
Copy link

does anyone know how to remove the "Find in text" placeholder text in the findbar?

@BoomerangAide
Copy link

BoomerangAide commented Sep 25, 2021

#417 (comment)
@bendover22 : we must be going for a different effect after all. Your code has no effect over my situation:

Not resized forcefully through javascript

ffox_navbar_not_resized



Resized forcefully through javascript

ffox_navbar_resized

I hope you managed to get things to look like how you wanted.
Note: this is on Firefox 91, maybe some things would get unlocked on another more recent version.

@ghost
Copy link

ghost commented Sep 25, 2021

Hello everyone. Is there any way I can make the appmenu completely square?
appbuton

@Aris-t2
Copy link
Owner Author

Aris-t2 commented Sep 26, 2021

@bendover22
@BoomerangAide

This worked for me without breaking other code.
Not sure, if it interferes with anything else.

:root {
  --urlbar-container-height: 40px !important;
  --urlbar-min-height: calc( var(--urlbar-container-height) - 2px ) !important;
}

@Acid-Crash
This will override folder icons with a custom SVG image, that can be colorized:

toolbarbutton.bookmark-item[container],
.bookmark-item[container] .menu-iconic-left .menu-iconic-icon,
.bookmark-item[query][hostContainer],
.folder-icon,
#editBMPanel_chooseFolderMenuItem .menu-iconic-icon,
treechildren::-moz-tree-image(title, container),
treechildren::-moz-tree-image(title, query, hostContainer) {
 -moz-image-region: rect(0px, 16px, 16px, 0) !important;
 -moz-context-properties: fill !important;
 list-style-image: url("chrome://browser/skin/developer.svg")!important;
 fill: red !important;
}

toolbarbutton.bookmark-item[container][open],
.bookmark-item[container][open] .menu-iconic-left .menu-iconic-icon,
treechildren::-moz-tree-image(title, open),
.bookmark-item[query][hostContainer][open] {
 -moz-image-region: rect(0px, 16px, 16px, 0) !important;
 -moz-context-properties: fill !important;
 list-style-image: url("chrome://browser/skin/developer.svg")!important;
 fill: blue !important;
}

@mimecry
You can not hide the placeholder using CSS.

@porigonz

#main-window[tabsintitlebar] #PanelUI-button #PanelUI-menu-button {
  border-radius: 0 !important;
}

@silverwings15
Copy link

silverwings15 commented Sep 26, 2021

@Aris-t2 i managed to hide it using

input.findbar-textbox::placeholder {opacity: 0 !important;}

@Acid-Crash
Copy link

@Aris-t2

This will override folder icons with a custom SVG image, that can be colorized:

Tried this version, unfortunately it also affects other Bookmark-related icons:

  • History > clock icon
  • Tags > Tag icon
  • All bookmarks > Star icon
  • Bookmark Toolbar + Bookmark menu icons
  • Last visited, Most visited > Gear icon

Also, the every subfolder icon (for example Globe icon) color changes for the opened folder, meaning, that it is also partially affected

I do understand that this is a lot of work, but maybe you can still look at this...

bookmark

@BoomerangAide
Copy link

I don't have version 92 or above, but I think the trick is the elements you want changed would be .bookmark-item[container] and .bookmark-item[container][open] or an equivalent, and the elements you want unchanged are also it, and something more.
Either you need to find every "something more", and allow them to set themselves on their usual/default value, or maybe you need to find something common to all you want to exclude (data-l10n-idmaybe?) and exclude it with the css rule (not sure which one would work...if one work).

@ghost
Copy link

ghost commented Sep 27, 2021

@Aris-t2 Thank you.

@Aris-t2
Copy link
Owner Author

Aris-t2 commented Sep 27, 2021

@Acid-Crash

This was a summary of what the folder icon changes look like, if using the code from bookmark_icons_colorized.css file.

You can tweak it, but colors will always affect iconized folders/containers unless one overrides them manually later.

.bookmark-item[container],
treechildren::-moz-tree-image(container) {
 fill: red !important;
}

.bookmark-item[container][open],
treechildren::-moz-tree-image(container, open) {
 fill: blue !important;
}

Excluing [data-l10n-id] will work for bookmarks toolbar and bookmarks popups, but not for sidebar and library.

.bookmark-item[container]:not([data-l10n-id]),
treechildren::-moz-tree-image(container) {
 fill: red !important;
}

.bookmark-item[container]:not([data-l10n-id])[open],
treechildren::-moz-tree-image(container, open) {
 fill: blue !important;
}

That would require to remove the fill rule from containers with icons manually.

I only know some of their names:

treechildren::-moz-tree-image(container, OrganizerQuery_BookmarksToolbar),
treechildren::-moz-tree-image(container, queryFolder_toolbar_____),
treechildren::-moz-tree-image(container, OrganizerQuery_BookmarksMenu),
treechildren::-moz-tree-image(container, queryFolder_menu________),
treechildren::-moz-tree-image(container, OrganizerQuery_UnfiledBookmarks),
treechildren::-moz-tree-image(container, queryFolder_unfiled_____),
treechildren::-moz-tree-image(container, OrganizerQuery_History),
treechildren::-moz-tree-image(container, OrganizerQuery_history____v),
treechildren::-moz-tree-image(container, OrganizerQuery_downloads__v),
treechildren::-moz-tree-image(container, OrganizerQuery_allbms_____v),
treechildren::-moz-tree-image(container, tagContainer),
treechildren::-moz-tree-image(container, OrganizerQuery_tags_______v) {
 fill: unset !important;
}

EDIT

I looked through the code and found a few more "names".

That should cover all items incl. sidebar and library now. Based on the above entries one could write custom code for those containers independent of the "default folder icons".

@plomari
Copy link

plomari commented Oct 3, 2021

Is there anything that rectifies all the round UI buttons? I looked here but there doesn't seem to be anything.

Is it correct that scrollbars both in the Firefox UI and web content (assuming the website doesn't override them) are defined by the system toolkit? They changed to the worse when updating from Firefox 88 to 92: instead of an elaborate rendering of a scrollbar, it's a grey rectangle with a grey oval as "handle" in it. This is on Linux. Firefox 92 is built against GTK 3, and Firefox 88 probably as well but not sure. Does anyone know why it changed and how it can be fixed? I found and modified this to make it look slightly better, but it's still ugly and with worse usability.

@BoomerangAide
Copy link

I feel like some compact-ness has hit the wrong place in latest css:

Version 78.14 ESR (normal)

78 14 esr

Version 91.0.2

91 0 2

Disabling "popup_compact_menus" make it look better (though not as good as in the past), I wonder if it's possible to exclude that popup (or whatever it should be called) from the "compact" changes?

On a more personal point (so low priority), I don't like the new "shield" icon (look like an empty vessel to me), I would be interested in getting the old one back / seeing it customizable in the future.

@BoomerangAide
Copy link

Not editing the previous entry since it's completely unrelated:
After some struggle in Aris-t2/CustomJSforFx#29 (comment) I managed to get back a warning icon for pages whose loading is broken.
But horror: Mozilla changed the icon from an orange one to a full black one, and that meant that what worked on Firefox 78:

#favimginurlbar[style*="warning.svg"]
{
	filter: hue-rotate(-45deg) saturate(100);
}

was now broken on Firefox 91.
But I managed to get around it with the following code:

#favimginurlbar[style*="warning.svg"]
{
	filter: invert(100%) brightness(50%) sepia(100%) hue-rotate(-45deg) saturate(10000%);
}

I don't know if other icons one want from black to another color will show up, but maybe my experience will be useful.

@Aris-t2
Copy link
Owner Author

Aris-t2 commented Oct 6, 2021

@plomari
By default the buttons have rounded corners, but modifying buttons_on_navbar_button_roundness.css can create fully squared buttons.

Besides custom_scrollbar_appearance.css custom JavaScript can also modify scrollbars.
Look here:
https://github.com/Aris-t2/CustomJSforFx
https://github.com/Aris-t2/CustomJSforFx/blob/master/scripts/custom_scrollbars.uc.js

@BoomerangAide
I will tweak the code a bit to optimize that popup when popup_compact_menus is active.

It should be possible to replace the shield icon with the old one:
tracking protection icon

#urlbar-input-container[pageproxystate="valid"] > #tracking-protection-icon-container > #tracking-protection-icon-box > #tracking-protection-icon {
  list-style-image: url(tracking-protection.svg) !important;
}

#urlbar-input-container[pageproxystate="valid"] > #tracking-protection-icon-container > #tracking-protection-icon-box[hasException] > #tracking-protection-icon {
  list-style-image: url(tracking-protection-disabled.svg) !important;
}

#urlbar-input-container[pageproxystate="valid"] > #tracking-protection-icon-container > #tracking-protection-icon-box:not([hasException])[active] > #tracking-protection-icon {
  list-style-image: url(tracking-protection.svg) !important;
}

@Aris-t2
Copy link
Owner Author

Aris-t2 commented Jan 29, 2022

If no option names/urls get changed between updates, replacing old "css" folder with new one should be enough.

@jmcken1
Copy link

jmcken1 commented Jan 29, 2022

@Aris-t2 I’m not sure I understand the instructions correctly. I created a “author_style_sheet.css” file in my chrome folder with your code:

#main-window[sizemode="fullscreen"] #PanelUI-button {
  display: none !important;
}

Then, that link doesn’t really say what to do with the code JS there. I tried copying the code directly into a new file, “author_style_sheet.js” in the chrome folder, but after restarting Firefox nothing happens; the appbutton is still visible in fullscreen mode.

I know zero about how to work with JS; what exactly should I do?

@Aris-t2
Copy link
Owner Author

Aris-t2 commented Jan 29, 2022

Use "method 2" instructions on CustomJSforFx main page: https://github.com/Aris-t2/CustomJSforFx

There is although a thread about JS there: Aris-t2/CustomJSforFx#29

@jmcken1
Copy link

jmcken1 commented Jan 29, 2022

@Aris-t2 Thanks for the link, but … I really have no idea what to do with the files/folders there. 😅 Do I use the files in “firefox”, “profile”, or both? Do I need the “userChrome.js” that’s described as “update alternative_searchbar.uc.js”? Where do I put the files? Do I need to edit any of them?

I took a look at the thread you linked, and it’s all waaay over my head, sorry.

@Aris-t2
Copy link
Owner Author

Aris-t2 commented Jan 29, 2022

Sorry, this was a misunderstanding.

The #main-window[sizemode="fullscreen"] #PanelUI-button... code belongs at the end of your my_userChrome.css file.


The other question about the scrollbuttons has to be solved by using the JS script.
You download the files provided there inside "method 2" folder and follow the instructions on the main page: https://github.com/Aris-t2/CustomJSforFx#method-2---files-in-install-and-profile-folders

@jmcken1
Copy link

jmcken1 commented Jan 30, 2022

Thanks. It works. 👍🏻

@plomari
Copy link

plomari commented Feb 1, 2022

Updating from 96.0.1 to 96.0.3 messed up my tab bar's height. It looks like #442 and #439. (Strangely, the reporter of the first issue claimed updating to 96.0.1 caused this, while 96.0.1 was fine to me, and it's broken with 96.0.3 instead.) I'm also using tabs_below_navigation_toolbar.css, and it looks like the tab bar's height is too large, and covers part of the navigation bar.

My userChrome.css is a mess of copy pasted .css files (since I apparently didn't understand how to use them "correctly"). The tabs_below_navigation_toolbar.css part is now exactly the same as 4.1.3, but the problem persists. I didn't find any other change in 00411af which seemed to help.
What could be wrong?

By the way, adjusting the "--classic_squared_tabs_tab_height" variable allowed me to move the tab bar further down, so it stopped overlapping with the navigation bar. But the tab bar's height is still too large and wastes space. (I assume the variable controls the space reserved for the tab bar, while the tab bar's actual height is determined or expanded by something else.)

@daemonspudguy
Copy link

Is it possible for someone to make a CTR-esque application using these files?

@Aris-t2
Copy link
Owner Author

Aris-t2 commented Feb 1, 2022

@plomari
Please use the full release of this projects files. Many files import other files, so it is possible, that something went wrong combining different releases.

@daemonspudguy
I doubt anyone has interest in creating this. I won't, sorry.

@ekorobow
Copy link

ekorobow commented Feb 1, 2022

How can I change the font size in the sidebar?

@BoomerangAide
Copy link

BoomerangAide commented Feb 2, 2022

I'm currently experimenting on a Firefox 96.0.3 portable because I'm trying to get rid of some glitchiness of the download button while using the ie6 button style.
I tweaked my old customization code (though some of it may be is definitely outdated/doing nothing nowadays, and some of it may have been put in during testing, but really did nothing, it just ended up being there when things started to look good, so I kept it) into that:

/* Prevent download button from turning into something else */

#downloads-button:-moz-any([progress],[counter],[paused],[attention]) #downloads-indicator-progress-outer,
#downloads-button[attention] > #downloads-indicator-anchor > #downloads-indicator-icon {
	background: -moz-image-rect(url("./image/toolbar_fx_ie6.png"), 0, 198, 18, 180) center no-repeat !important;
}

#downloads-button[indicator="true"] {
	list-style-image: url("./image/toolbar_fx_ie6.png") !important;
	-moz-image-region: rect(0px, 198px, 18px, 180px) !important;
}

#downloads-button[attention] {
  color: #005F00 !important;
  font-weight: bold !important;
}

#downloads-indicator-start-image, #downloads-indicator-finish-image {
	list-style-image: url("./image/toolbar_fx_ie6.png") !important;
	-moz-image-region: rect(0px, 198px, 18px, 180px) !important;
}

#downloads-indicator-progress-outer {
	border: none !important;
}

#downloads-indicator-progress-inner{
	display: none !important;
}
/**/

/* Remove a blue dot introduced in Custom CSS 4 and/or Fx 91 */
#downloads-button:is([progress],[counter],[paused],[attention])::after,
.toolbarbutton-badge {
	display: none !important;
}
/**/

There's still some glitchiness happening at a download end before the image become back normal.
I wonder if there's a way to get rid of it with more CSS code, or if it may be using js and then I would have to move my question to the other project I guess.
By the way, I call it "glitchiness" because the weird distortion I observe may be using the ie6 icon as a base, or maybe I'm seeing too much into that Picasso/mosaic censorship collaboration lol.

@SGvagon
Copy link

SGvagon commented Feb 8, 2022

Hello, Firefox ESR now released version 91.6.0esr , where Compact mode not working on Tabbar (tabs) . Tabs have 32px maybe more and I can't set default 28px , so I had to make my fix for it.
Here is the code to my_userChrome.css :

#TabsToolbar {
height: 28px !important;
}

.tabbrowser-tab .tab-label, .tabbrowser-tab .tab-icon-image, .tab-close-button, .tab-throbber, .tabbrowser-tab[pinned] :-moz-any(.tab-icon-overlay[soundplaying]), .tabbrowser-tab :-moz-any(.tab-icon-sound, .tab-icon-overlay[soundplaying]) {
margin-top: -5px !important;
}

@media (-moz-windows-classic) {
.tabbrowser-tab .tab-label, .tabbrowser-tab .tab-icon-image, .tab-close-button, .tab-throbber, .tabbrowser-tab[pinned] :-moz-any(.tab-icon-overlay[soundplaying]), .tabbrowser-tab :-moz-any(.tab-icon-sound, .tab-icon-overlay[soundplaying]) {
margin-top: -2px !important;
}
}

Before:
Before

After:
After

Hope this helps someone :) .
Oh, I see that you fixed in version 4.1.3 , but this fix is for Firefox 97, but I have this issue in the latest ESR, strange. But my fix working too, but it has more complicated code than your fix with height: unset !important; .

@Aris-t2
Copy link
Owner Author

Aris-t2 commented Feb 10, 2022

@ekorobow

tree.sidebar-placesTree {
  font-size: 20pt !important;
}

@BoomerangAide
I tried to get to the default downloads buttons code as much as possible in v4.1.3, when using custom icon sets.
Probably the old ie6 icons do not look as good as they used to back then?
The mentioned weir behavior is probably caused by the animations Mozilla is using.

Btw. #downloads-button:is([progress],[counter],[paused],[attention])::after was removed in 4.1.3 too. The badge is gone.

@SGvagon
Most likely they backported Fx97 tab code changes to ESR. Such a move on ESR channel betrays its purpose, but we are talking about Mozilla here.

@SGvagon
Copy link

SGvagon commented Feb 10, 2022

@Aris-t2 : Yes, that's a reason why I am using ESR, but Mozilla makes too much changes in design here too :-/ . As you said, this is betrays its purpose.

@mzso
Copy link

mzso commented Feb 10, 2022

Hi!

Can't the jumping items be improved when two rows are set for URL-bar? Such as when you hover over a switch to tab item and press alt.
Unlike in normal single row format the URL doesn't replace the switch-to-tab text (for whatever reason), but is added in a new line, so it causes everything to jump. It can be rather jarring.

@Achille-Grs
Copy link

Hi @Aris-t2 how are you?! In Firefox 97 as you can see the pic, I use full darkmode theme but I changed the background of Navigator Toobox with linear-grantient code, and everything is fine.
My probleme is the download button colors of the progress, I tryed to change the colors without any luck.
The buttons 1(blue) and 5(red) it's right, but the 2, 3 and 4 (very light blue) I want it to different color.
Is there a solution?
Thank you!
Στιγμιότυπο οθόνης (41)

@mzso
Copy link

mzso commented Feb 10, 2022

Also:
I'm using a couple items for about:addons.

@import "./css/aboutaddons/addonlists_show_addon_version_number.css"; /**/
@import "./css/aboutaddons/addonlists_compact.css"; /**/
@import "./css/aboutaddons/addonlists_show_buttons_instead_of_menu_popup_compact_view.css"; /**/
@import "./css/aboutaddons/addons_manager_alternative_appearance_compact_categories.css"; /**/
@import "./css/aboutaddons/recentupdates_category_always_visible.css"; /**/
@import "./css/aboutaddons/availableupdates_category_always_visible.css"; /**/

But something borks the highlights for categories inside about:addons. Only icons are highlighted:
kép

@Jee-Hex
Copy link

Jee-Hex commented Feb 10, 2022

but this fix is for Firefox 97, but I have this issue in the latest ESR, strange.

They backported bug 1714276 to 96.0.2 and then 91.6.0esr. Gotta give it up to mozilla because this was the first time I ever have to update css tweaks mid-esr cycle.

@Aris-t2 Please also consider applying this height fix to default_tabs_photon.css and possibly other custom tab appearances.

Edit: Hmm seems like the height fix is only necessary for default_tabs_photon.css when using linux builds? I am not seeing any differences when using 91.6.0esr windows builds...

@click-click
Copy link

click-click commented Feb 11, 2022

Since moving from Firefox ESR 91.5.1 to 91.6.0, my Tabs no longer retain their customized size.

/****************************************************************
Override Normal Density height to Compact Density height for tabs
****************************************************************/

#TabsToolbar, #tabbrowser-tabs { --tab-min-height: 16px !important; }

The above code no longer works. Is there any other code that I could try to get back the original size?
TabBefore
TabNow

@SGvagon
Copy link

SGvagon commented Feb 11, 2022

@click-click If my code for my_Userchrome above not working, you have to update Aris pack to the newest version.

@click-click
Copy link

click-click commented Feb 11, 2022

Thank you SGvagon. I tend to forget checking the release and change logs. I updated from 4..1.1 to 4.1.4 and my smaller tabs are back again. It's a never ending battle with Mozilla Development always futzing around with the GUI. They should be made to develop with tiny screens to see how much space gets wasted by their actions. :-(

I see someone did not like my comment. Okay, I take it all back. I was told that the developers fixed something to help Linux users in the 97/91.6 update which is fine with me.

@click-click
Copy link

click-click commented Feb 11, 2022

@SGvagon Do you know what changed in FF 91.6 to make the snippet I used in my_Userchrome.css to stop working?

@SGvagon
Copy link

SGvagon commented Feb 11, 2022

@click-click The tabs height for classic squared tabs is set in config\general_variables.css on line 13

  --classic_squared_tabs_tab_height: 28px !important;

And the change is in css\tabs\classic_squared_tabs.css on the last lines 489-492 , that fixed the custom tabs height what I see. Just look at changelog of version 4.1.3 what Aris changed :-) . 00411af .

/* Fx 97+ height fix */
#tabbrowser-tabs:not([secondarytext-unsupported]) .tab-label-container {
  height: unset !important;
}

I am not a pro in this, but this is all what I know at the moment :) .

@glennpc
Copy link

glennpc commented Feb 11, 2022

A couple of issues with Nightly 99:

There's an added space between the menubar & toolbar and
popup_compact_menus don't look the same anymore compared with Beta 98 and Released 97.

nightly

Here's what the popup_compact_menus looked like before:

97 0

@Aris-t2
Copy link
Owner Author

Aris-t2 commented Feb 12, 2022

@mzso
Tried to remove the jumping for ac_popup_megabar_title_and_url_two_lines.css in latest dev build.

addons_manager_alternative_appearance_compact_categories.css caused the glich in add-ons manager.

@Achille-Grs

Override download buttons progress colors:

#downloads-indicator-progress-inner {
  background: conic-gradient(green var(--download-progress-pcent), transparent var(--download-progress-pcent)) !important;
}

#downloads-indicator-start-image {
  fill: orange !important;
  stroke: orane !important;
}

#downloads-indicator-finish-image {
  fill: red !important;
  stroke: red !important;
}

@glennpc
Mozilla renamed some @media rules. That caused the issue where OS specific code (win10, 8, 7) was not applied at all.

@ALL
v4.1.5pre3 fixes the above mentioned issues.
https://github.com/Aris-t2/CustomCSSforFx/releases/tag/4.1.5pre

@Aris-t2
Copy link
Owner Author

Aris-t2 commented Feb 13, 2022

Continue here: #452

@Aris-t2 Aris-t2 closed this as completed Feb 13, 2022
@Aris-t2 Aris-t2 unpinned this issue Feb 13, 2022
Repository owner locked as too heated and limited conversation to collaborators Feb 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests