Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fx117+] Expanding spacer isn't working correctly in menu bar #99

Open
Aleksandra0056 opened this issue Sep 6, 2023 · 5 comments
Open

Comments

@Aleksandra0056
Copy link

Aleksandra0056 commented Sep 6, 2023

Describe the issue:

Expanding spacer in space_and_separator_restorer.uc.js isn't working correctly in menu bar, because it expands the space only to a half.

What should have happened instead?

Expanding spacer should expand space in the entire menu bar.

Steps to reproduce the issue?

Make you sure, that you have space_and_separator_restorer.uc.js installed in Firefox!

  1. Open Firefox,
  2. Enable menu bar,
  3. Add some buttons next to “Help” button (which is located in menu bar),
  4. Add an expanding spacer between the menu bar and buttons next to it.

Screenshots (drag and drop images into this post):

Expanding spacer isn't working correctly

  • Red arrow is pointing to actual position of buttons,
  • Blue line is showing where these buttons should be located.

System information

@Aris-t2
Copy link
Owner

Aris-t2 commented Sep 6, 2023

Actually that is supposed to happen. The menu already has a spacer:
image

Remove it using this CSS:

#toolbar-menubar > spacer {
  display: none !important;
}

@Aleksandra0056
Copy link
Author

Thank you, it worked! I'm proposing to keep this open, because other people maybe have this issue too, so they would see this workaround better.

By the way, can you tell me how can I enable the new Firefox View icon? I saw it in your screenshot, and it is better than the original orange icon. I don't want code for it, but I want to know if there exists about:config entry in Firefox 117.0, or it is only available on Nightly?

@Aris-t2
Copy link
Owner

Aris-t2 commented Sep 6, 2023

The icon is the default one Nightly uses. You can not enable it through about:config.

I can add this to CustomCSSforFx for appmenu button on next update.

image

@Aleksandra0056
Copy link
Author

Aleksandra0056 commented Sep 6, 2023

I meant this icon. And not for appmenu button, but for Firefox View button.

image

@mzso
Copy link

mzso commented Sep 2, 2024

@Aris-t2 commented on Sep 6, 2023, 7:06 PM GMT+2:

Actually that is supposed to happen. The menu already has a spacer:
https://github.com/Aris-t2/CustomJSforFx/assets/6013569/a66de604-b1c1-41a3-bb1c-3f58ccc15db5

Remove it using this CSS:

#toolbar-menubar > spacer {
  display: none !important;
}

Originally posted by @Aris-t2 in #99 (comment)

This doesn't seem to work for me (FF130). The empty space on the right remains.
But I don't see any element there with DOMi.
Edit: Never mind... Forgot to updated the script first. And I just assumed it was working fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants