Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] timeout error for other coroutines if task is synchronous function that takes too long to run #3844

Closed
Tracked by #3398
RogerHYang opened this issue Jul 4, 2024 · 0 comments · Fixed by #3846
Assignees
Labels
bug Something isn't working

Comments

@RogerHYang
Copy link
Contributor

RogerHYang commented Jul 4, 2024

Below is the errors you'll see in the guidlines_eval.ipynb notebook.

Screenshot 2024-07-03 at 7 03 28 PM

The root cause of this is that the task is defined to be synchronous and its network call is blocking the execution long enough to cause some of the await post to the phoenix server to be timed out.

To reproduce, use time.sleep. See below.

Screenshot 2024-07-05 at 9 09 20 AM

Note that the Phoenix server received all 7 traces in the above screenshot, but not all 7 experiment runs.

@RogerHYang RogerHYang added bug Something isn't working triage issues that need triage labels Jul 4, 2024
@github-project-automation github-project-automation bot moved this to 📘 Todo in phoenix Jul 4, 2024
@RogerHYang RogerHYang changed the title [BUG] Connection timeout when task is sync function with LLM calls over the network [BUG] Connection timeout when task is synchronous function with LLM calls over the network Jul 4, 2024
@RogerHYang RogerHYang self-assigned this Jul 4, 2024
@RogerHYang RogerHYang moved this from 📘 Todo to 👨‍💻 In progress in phoenix Jul 4, 2024
@RogerHYang RogerHYang removed the triage issues that need triage label Jul 4, 2024
@RogerHYang RogerHYang changed the title [BUG] Connection timeout when task is synchronous function with LLM calls over the network [BUG] timeout error for other coroutines if task is synchronous function that takes too long to run Jul 4, 2024
@RogerHYang RogerHYang moved this from 👨‍💻 In progress to 🔍. Needs Review in phoenix Jul 8, 2024
@github-project-automation github-project-automation bot moved this from 🔍. Needs Review to ✅ Done in phoenix Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant