Add confirmation to warn user of the cost of second passphrase #435
Conversation
There was a problem hiding this comment.
I like the idea, but some people may ignore the notice message, so probably the best way to avoid that is:
- Change the text, to reflect that it's necessary to back-up the passphrase AND pay n ARK.
- Show a confirmation after clicking NEXT that informs that it's necessary to back-up the passphrase and pay n ARK.
client/app/config/config.js
Outdated
| @@ -1,7 +1,7 @@ | |||
| module.exports = { | |||
| notice: { | |||
| logFile: false, | |||
| level: 1, | |||
| level: 2, | |||
There was a problem hiding this comment.
The main reason for that change is because every time we send a toast message some message types are shown to the user such as error, success, but others are supposed to be logged only such as log and debug. I believe warning should be shown to the user so I made it level 2 instead of 1.
Currently it does
if (type > self.loggingType) {
self.logToFile(message, typeName)
return
}
When ya say a confirmation, do you mean a popup kinda so they click 'I agree' or something like that? Instead of a toast message?
There was a problem hiding this comment.
Yes, a confirmation would be a new intermediate screen after clicking "NEXT" on the same window, or a pop-up with "I agree" or something similar.
There was a problem hiding this comment.
Added an alert that shows before the secondPassphrase generation starts. They must hit OK before continuing.
The toast message is also there still.
There was a problem hiding this comment.
Good work.
I'd remove the toast message because toast notices should be a way to reflect the end of an action on the background, an error, etc. In this case, is unnecessary and it could even be distracting.
Apart from that, the only change I'd do is using different texts:
"Are you sure?" => "Second passphrase fee"
"WARNING! Second passphrase creation costs ' + secondPhraseArkVal + ' '+ currency +'.'"
"CREATE" => "CONTINUE"
There was a problem hiding this comment.
Should I keep the changes to the levels though? Since we do want toast warnings to be shown not logged? Or should I revert that back?
Agreed with the changes, I'll get those done soon.
EDIT: I agree, if there's a consensus to change it I'd be glad to get that fix rolled out!
There was a problem hiding this comment.
I'd remove entirely the toast message and I'd revert the notice configuration to level 1.
There was a problem hiding this comment.
I got rid of the toast message and reverted the notice!
client/app/config/config.js
Outdated
| @@ -1,7 +1,7 @@ | |||
| module.exports = { | |||
| notice: { | |||
| logFile: false, | |||
| level: 1, | |||
| level: 2, | |||
There was a problem hiding this comment.
Good work.
I'd remove the toast message because toast notices should be a way to reflect the end of an action on the background, an error, etc. In this case, is unnecessary and it could even be distracting.
Apart from that, the only change I'd do is using different texts:
"Are you sure?" => "Second passphrase fee"
"WARNING! Second passphrase creation costs ' + secondPhraseArkVal + ' '+ currency +'.'"
"CREATE" => "CONTINUE"
j-a-m-l
changed the title
|
+5 Good work! |
Some people on the subreddit were mentioning there wasn't any popup or information about how creating a second passphrase costs ark. This toast warning message should popup and warn them how much it'll cost!