fix(crypto): make transaction amount required (#2574)

ArkEcosystem · May 13, 2019 · e6c8406 · e6c8406
1 parent d2b426e
commit e6c8406
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/__tests__/unit/core-transactions/handler-registry.test.ts b/__tests__/unit/core-transactions/handler-registry.test.ts
@@ -21,7 +21,7 @@ class TestTransaction extends Transactions.Transaction {
     public static getSchema(): Transactions.schemas.TransactionSchema {
         return extend(transactionBaseSchema, {
             $id: "test",
-            required: ["recipientId", "amount", "asset"],
+            required: ["recipientId", "asset"],
             properties: {
                 type: { transactionType: TEST_TRANSACTION_TYPE },
                 recipientId: { $ref: "address" },

diff --git a/packages/crypto/src/transactions/types/schemas.ts b/packages/crypto/src/transactions/types/schemas.ts
@@ -16,7 +16,7 @@ const strictTransaction = {
 export const transactionBaseSchema = {
     $id: undefined,
     type: "object",
-    required: ["type", "senderPublicKey", "fee", "timestamp"],
+    required: ["type", "senderPublicKey", "fee", "amount", "timestamp"],
     properties: {
         id: { anyOf: [{ $ref: "transactionId" }, { type: "null" }] },
         version: { enum: [1, 2] },
@@ -58,7 +58,7 @@ export const strictSchema = (schema: TransactionSchema): TransactionSchema => {
 
 export const transfer = extend(transactionBaseSchema, {
     $id: "transfer",
-    required: ["recipientId", "amount"],
+    required: ["recipientId"],
     properties: {
         type: { transactionType: TransactionTypes.Transfer },
         vendorField: { anyOf: [{ type: "null" }, { type: "string", format: "vendorField" }] },