test(core-p2p): increase test coverage (#4004)

ArkEcosystem · Sep 7, 2020 · faaf4e1 · faaf4e1
1 parent bf892b5
commit faaf4e1
Show file tree

Hide file tree

Showing 5 changed files with 112 additions and 5 deletions.
diff --git a/__tests__/unit/core-p2p/socket-server/routes/blocks.test.ts b/__tests__/unit/core-p2p/socket-server/routes/blocks.test.ts
@@ -0,0 +1,49 @@
+import { Container } from "@packages/core-kernel";
+
+import { BlocksRoute } from "@packages/core-p2p/src/socket-server/routes/blocks";
+
+describe("BlocksRoute", () => {
+    let blocksRoute: BlocksRoute;
+
+    const container = new Container.Container();
+
+    const logger = { warning: jest.fn(), debug: jest.fn() };
+    const controller = { getPeers: jest.fn() }; // a mock peer controller
+    const app = { resolve: jest.fn().mockReturnValue(controller) };
+    const server = { bind: jest.fn(), route: jest.fn() };
+
+    beforeAll(() => {
+        container.unbindAll();
+        container.bind(Container.Identifiers.LogService).toConstantValue(logger);
+        container.bind(Container.Identifiers.Application).toConstantValue(app);
+    });
+
+    beforeEach(() => {
+        blocksRoute = container.resolve<BlocksRoute>(BlocksRoute);
+    });
+
+    it("should bind the controller to the server and register the routes", () => {
+        const routes = blocksRoute.getRoutesConfigByPath();
+        const routesExpected = Object.entries(routes).map(([path, config]) => ({
+            method: "POST",
+            path,
+            config: {
+                id: config.id,
+                handler: config.handler,
+                payload: {
+                    maxBytes: config.maxBytes,
+                },
+            },
+        }));
+
+        blocksRoute.register(server);
+
+        expect(server.bind).toBeCalledTimes(1);
+        expect(server.bind).toBeCalledWith(controller);
+
+        expect(server.route).toBeCalledTimes(routesExpected.length);
+        for (const route of routesExpected) {
+            expect(server.route).toBeCalledWith(route);
+        }
+    });
+});
diff --git a/__tests__/unit/core-p2p/socket-server/routes/transactions.test.ts b/__tests__/unit/core-p2p/socket-server/routes/transactions.test.ts
@@ -0,0 +1,49 @@
+import { Container } from "@packages/core-kernel";
+
+import { TransactionsRoute } from "@packages/core-p2p/src/socket-server/routes/transactions";
+
+describe("BlocksRoute", () => {
+    let tranasctionsRoute: TransactionsRoute;
+
+    const container = new Container.Container();
+
+    const logger = { warning: jest.fn(), debug: jest.fn() };
+    const controller = { getPeers: jest.fn() }; // a mock peer controller
+    const app = { resolve: jest.fn().mockReturnValue(controller) };
+    const server = { bind: jest.fn(), route: jest.fn() };
+
+    beforeAll(() => {
+        container.unbindAll();
+        container.bind(Container.Identifiers.LogService).toConstantValue(logger);
+        container.bind(Container.Identifiers.Application).toConstantValue(app);
+    });
+
+    beforeEach(() => {
+        tranasctionsRoute = container.resolve<TransactionsRoute>(TransactionsRoute);
+    });
+
+    it("should bind the controller to the server and register the routes", () => {
+        const routes = tranasctionsRoute.getRoutesConfigByPath();
+        const routesExpected = Object.entries(routes).map(([path, config]) => ({
+            method: "POST",
+            path,
+            config: {
+                id: config.id,
+                handler: config.handler,
+                payload: {
+                    maxBytes: config.maxBytes,
+                },
+            },
+        }));
+
+        tranasctionsRoute.register(server);
+
+        expect(server.bind).toBeCalledTimes(1);
+        expect(server.bind).toBeCalledWith(controller);
+
+        expect(server.route).toBeCalledTimes(routesExpected.length);
+        for (const route of routesExpected) {
+            expect(server.route).toBeCalledWith(route);
+        }
+    });
+});
diff --git a/__tests__/unit/core-p2p/socket-server/server.test.ts b/__tests__/unit/core-p2p/socket-server/server.test.ts
@@ -23,7 +23,7 @@ describe("Server", () => {
 
     const container = new Container.Container();
 
-    const logger = { warning: jest.fn(), debug: jest.fn() };
+    const logger = { warning: jest.fn(), debug: jest.fn(), info: jest.fn() };
     const app = {
         log: logger,
         terminate: jest.fn(),
@@ -50,6 +50,7 @@ describe("Server", () => {
         hapiServer.inject = jest.fn();
         hapiServer.route = jest.fn();
         hapiServer.register = jest.fn();
+        hapiServer.info = { uri: "" };
     });
 
     const name = "P2P server";
@@ -86,7 +87,8 @@ describe("Server", () => {
             await server.initialize(name, options);
             await server.boot();
 
-            expect(hapiServer.start).toBeCalledTimes(1);
+            expect(hapiServer.start).toBeCalledTimes(3);
+            expect(app.terminate).not.toBeCalled();
         });
 
         it("should terminate app if server.start() failed", async () => {
@@ -105,7 +107,8 @@ describe("Server", () => {
             await server.initialize(name, options);
             await server.dispose();
 
-            expect(hapiServer.stop).toBeCalledTimes(1);
+            expect(hapiServer.stop).toBeCalledTimes(3);
+            expect(app.terminate).not.toBeCalled();
         });
 
         it("should terminate app if server.stop() failed", async () => {

diff --git a/__tests__/unit/core-p2p/utils/build-rate-limiter.test.ts b/__tests__/unit/core-p2p/utils/build-rate-limiter.test.ts
@@ -1,5 +1,10 @@
-//import { buildRateLimiter } from "@arkecosystem/core-p2p/src/utils/build-rate-limiter";
+import { buildRateLimiter } from "@packages/core-p2p/src/utils/build-rate-limiter";
+import { RateLimiter } from "@packages/core-p2p/src/rate-limiter";
 
 describe("buildRateLimiter", () => {
-    it.todo("");
+    it("should return instance of RateLimiter", () => {
+        const rateLimiter = buildRateLimiter({ whitelist: [], remoteAccess: [] });
+
+        expect(rateLimiter).toBeInstanceOf(RateLimiter);
+    });
 });
diff --git a/packages/core-p2p/src/peer-communicator.ts b/packages/core-p2p/src/peer-communicator.ts
@@ -273,6 +273,7 @@ export class PeerCommunicator implements Contracts.P2P.PeerCommunicator {
                 if (process.env.CORE_P2P_PEER_VERIFIER_DEBUG_EXTRA) {
                     this.logger.debug(`Socket error (peer ${peer.ip}) : ${error.message}`);
                 }
+                /* istanbul ignore else */
                 if (disconnect) {
                     this.events.dispatch(Enums.PeerEvent.Disconnect, { peer });
                 }