Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(core-p2p): increase test coverage to 100% #4004

Merged
merged 1 commit into from
Sep 7, 2020

Conversation

sebastijankuzner
Copy link
Contributor

@sebastijankuzner sebastijankuzner commented Sep 4, 2020

Summary

Solves #3980

Increase core-p2p coverage to 100 %.

Checklist

  • Tests (if necessary)
  • Ready to be merged

@codecov
Copy link

codecov bot commented Sep 4, 2020

Codecov Report

Merging #4004 into develop will increase coverage by 0.10%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4004      +/-   ##
===========================================
+ Coverage    98.49%   98.60%   +0.10%     
===========================================
  Files          631      631              
  Lines        14576    14576              
  Branches      1731     1731              
===========================================
+ Hits         14357    14373      +16     
+ Misses         128      113      -15     
+ Partials        91       90       -1     
Flag Coverage Δ
#functional 6.80% <ø> (ø)
#integration 9.88% <ø> (ø)
#unit 96.77% <ø> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/core-p2p/src/peer-communicator.ts 100.00% <ø> (+0.81%) ⬆️
packages/core-p2p/src/socket-server/server.ts 100.00% <0.00%> (+15.38%) ⬆️
packages/core-p2p/src/utils/build-rate-limiter.ts 100.00% <0.00%> (+33.33%) ⬆️
...ckages/core-p2p/src/socket-server/routes/blocks.ts 100.00% <0.00%> (+37.50%) ⬆️
.../core-p2p/src/socket-server/routes/transactions.ts 100.00% <0.00%> (+37.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bb4fed...ad22cfe. Read the comment docs.

@air1one air1one merged commit faaf4e1 into develop Sep 7, 2020
@ghost ghost deleted the test/core-p2p/increase-coverage branch September 7, 2020 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants