[Weekly Digest] Oct 21, 2019 - Oct 27, 2019

[ghost]

Here's the Weekly Digest from Mon, Oct 21, 2019 12:00 AM to Sun, Oct 27, 2019 11:59 PM for ArkEcosystem/core.

Issues

Last week there were 33 issues. Of these, 23 issues have been closed and 10 issues are still open.

Opened

@alessiodf

• [2.6][T4] TypeError: Cannot set property during HtlcClaimTransactionHandler.revertForSender #3116 TypeError: Cannot set property during HtlcClaimTransactionHandler.revertForSender

@dated

• [2.6][T2] multiple business and bridgechain updates allowed in transaction pool #3124 [2.6][T2] multiple business and bridgechain updates allowed in transaction pool
• duplicate bridgechain data #3111 [2.6][T3] duplicate bridgechain indices
• [2.6][T2] typeFromSenderAlreadyInPool method disregards typeGroup #3139 [2.6][T2] typeFromSenderAlreadyInPool method disregards typeGroup
• [2.6][T4] use core typegroup as default in transactions api #3144 [2.6][T4] use core typegroup as default in transactions api

@Lemii

• [2.6][T4] Discussion: Set 'Version: 2' as default or make it easier to configure #3099 Discussion: Set 'Version: 2' as default or make it easier to configure
• [2.6][T4] MaximumPaymentCountExceededError shows incorrect received amount #3133 [2.6][T4] MaximumPaymentCountExceededError shows incorrect received amount
• [2.6][T3] Perform validation on the website field of a business registration/update #3106 [2.6][T3] Perform validation on the website field of a business registration/update
• [2.6][T1] Unicode characters U+0000 to U+0080 allowed in certain business and bridgechain fields #3125 [2.6][T1] Unicode characters U+0000 to U+0080 allowed in certain business and bridgechain fields
• [2.6][T4] Redundant properties in genesisHash schema #3149 [2.6][T4] Redundant properties in genesisHash schema

Closed

@alessiodf

• Automatically add missing plugins in config file #3114 Automatically add missing plugins in config file
• [2.6][T2] Regression of Core-SV-027 in 2.6 #3102 [2.6][T2] Regression of Core-SV-027 in 2.6

@dated

• getMilestone doesn't return the latest milestone #3097 getMilestone doesn't return the latest milestone
• [2.6][T3] uniqueness of bridgechain names for the same business #3126 [2.6][T3] uniqueness of bridgechain names for the same business
• [2.6][T4] improve ordering of the peers api endpoint #3079 improve ordering of the peers api endpoint
• [2.6][T3] vendorfield of locks returned as buffer by the api #3134 [2.6][T3] vendorfield of locks returned as buffer by the api
• [2.6][T4] hardcoded cap for maximum amount of transactions per multi payment #3135 [2.6][T4] hardcoded cap for maximum amount of transactions per multi payment
• [2.6][T3] uniqueness of business name or website and combination thereof #3098 [2.6][T3] uniqueness of business name or website and combination thereof
• [2.6][T3] businesses/{id}/bridgechains endpoint not implemented #3115 [2.6][T3] businesses/{id}/bridgechains endpoint not implemented
• bridgechain names cannot be reassigned/updated #3131 bridgechain names cannot be reassigned/updated
• [2.6][T1] databaseservice connection not retrieved properly #3129 [2.6][T1] databaseservice connection not retrieved properly
• [2.6][T4] updating bridgechains emits "business.updated" event #3127 [2.6][T4] updating bridgechains emits "business.updated" event
• [2.6][T4] type of businessId and bridgechainId #3113 [2.6][T4] type of businessId and bridgechainId
• [2.6][T4] concrete type hints instead of interface from core-interfaces #3120 [2.6][T4] concrete type hints instead of interface from core-interfaces
• [2.6][T3] duplication of values in buildConstants() #3105 [2.6][T3] duplication of values in buildConstants()
• [2.6][T4] timestamp returned by locks endpoints #3090 [2.6][T4] timestamp returned by locks endpoints

@eugeneli

• Negative confirmations #3117 Negative confirmations

@galperins4

• [2.6][T4] - Sync from 0 does not work #3070 [2.6][T4] - Sync from 0 does not work

@Lemii

• [2.6][T4] Typegroup mismatch in /api/transactions/types endpoint and actual transaction data #3104 [2.6][T4] Typegroup mismatch in /api/transactions/types endpoint and actual transaction data
• /bridgechain/ endpoint returns duplicate data  #3122 /bridgechain/ endpoint returns duplicate data
• Increase the number of required seed nodes for bridgechain registrations #3107 Increase the number of required seed nodes for bridgechain registrations
• [2.6][T4] Misleading error message when updating a bridgechain not registered by the same business #3123 [2.6][T4] Misleading error message when updating a bridgechain not registered by the same business
• Reject business and bridgechain registrations that contain curse words #3100 Reject business and bridgechain registrations that contain curse words

Pull Requests

Last week, 30 pull-requests were opened, closed or merged.

Opened

Last week, 4 pull-requests were opened.

@dated

• refactor(core-api): fallback to core typegroup if querying by type #3147 [WIP] refactor(core-api): fallback to core typegroup if querying by type
• refactor(core-magistrate): don't allow multiple business or bridgechain updates for the same id #3137 [WIP] refactor(core-magistrate): don't allow multiple business or bridgechain updates for the same id

@Lemii

• polish(core-magistrate-crypto): remove redundant bridgechain schema properties #3150 polish(core-magistrate-crypto): remove redundant bridgechain schema properties
• fix(core-magistrate-crypto): improve 'name' field validation to avoid illegal characters #3148 fix(core-magistrate-crypto): improve 'name' field validation to avoid illegal characters

Merged

Last week, 26 pull-requests were merged.

@adrian69

• chore: update docker to node.js 12 #3101 chore: update docker to node.js 12

@alessiodf

• fix(core-p2p): properly terminate bad connections #3103 fix(core-p2p): properly terminate bad connections

@dated

• refactor(core-api): sort peers by height, latency #3078 refactor(core-api): sort peers by height, latency
• fix(core-magistrate-transactions): emit correct event #3128 fix(core-magistrate-transactions): emit correct event
• refactor(core-database): convert htlc lock vendorfield to string during bootstrap #3145 refactor(core-database): convert htlc lock vendorfield to string during bootstrap
• refactor(core-api): format timestamp of locks #3091 refactor(core-api): format timestamp of locks
• refactor(crypto): overwrite arrays when merging milestones #3108 refactor(crypto): overwrite arrays when merging milestones
• refactor(crypto): use multiPaymentLimit from milestone if available #3136 refactor(crypto): use multiPaymentLimit from milestone if available
• feat(core-magistrate): ensure unique bridgechain name per business #3132 feat(core-magistrate): ensure unique bridgechain name per business
• feat(core-api): implement businesses/bridgechains endpoint #3119 feat(core-api): implement businesses/bridgechains endpoint
• refactor(core-database): refactor searchBusinesses & searchBridgechains #3110 refactor(core-database): refactor searchBusinesses & searchBridgechains
• refactor(core-magistrate): business and bridgechain ids as numbers #3118 refactor(core-magistrate): business and bridgechain ids as numbers
• fix(core-magistrate): get connection from databaseservice #3130 fix(core-magistrate): get connection from databaseservice
• refactor(core-magistrate): use type from core-interfaces #3121 refactor(core-magistrate): use type from core-interfaces

@faustbrian

• Revert "refactor(core-magistrate-crypto): consolidate bridgechain schema and streamline its usage" #3146 Revert "refactor(core-magistrate-crypto): consolidate bridgechain schema and streamline its usage"

@Lemii

• refactor(core-magistrate-crypto): consolidate bridgechain schema and streamline its usage #3143 refactor(core-magistrate-crypto): consolidate bridgechain schema and streamline its usage
• refactor(core-magistrate-transactions): BridgechainUpdate errors #3141 refactor(core-magistrate-transactions): BridgechainUpdate errors

@supaiku0

• fix(core-p2p): uncaught IPC timeout #3140 fix(core-p2p): uncaught IPC timeout
• fix(core-blockchain): add transactions back to pool only after reverting all blocks #3138 fix(core-blockchain): add transactions back to pool only after reverting all blocks
• fix(core-database): set last height before initializing last block to use correct milestones #3109 fix(core-database): set last height before initializing last block to use correct milestones
• fix(core): read paths.config instead of env variable #3142 fix(core): read paths.config instead of env variable
• feat: expose transaction height, blockId and generatorPublicKey during bootstrap #3096 feat: expose transaction height, blockId and generatorPublicKey during bootstrap
• fix(core-transactions): throw if transaction key is already taken #3095 fix(core-transactions): throw if transaction key is already taken

@vasild

• fix(core-api): use numerics for typeGroups in /transactions/types #3112 fix(core-api): use numerics for typeGroups in /transactions/types
• chore: print more details in log messages #3089 chore: print more details in log messages
• fix(core-p2p): parallel download #3092 fix(core-p2p): parallel download

Releases

Last week there were no releases.

Contributors

Last week there were 7 contributors.

@adrian69 @alessiodf @dated @faustbrian @Lemii @supaiku0 @vasild

Thank you for your contributions! 🎉

Star Gazers

Last week there was 1 stargazer.

@neoxian

You are the star! 🌟

---

That's all activities since Mon, Oct 21, 2019 12:00 AM, please Watch and Star the repository ArkEcosystem/core to receive upcoming weekly updates.

You can also view all Weekly Digests by clicking here.