ForgerMissing fires with incorrect delegate at the start of a new round/end of an old round

[alessiodf]

During round 221,196 on mainnet the ForgerMissing event was incorrectly fired.

For reference the round order was: arknet, quarkpool, cactus1549, doc, cams_yellow_jacket, arkmoon, bioly, tibonos, calidelegate, espresso, fun, echo, ghostfaceuk, drakeler, civseed, deadlock, thefoundry, dated, arkworld, arkane, thegoldenhorde, samuray, lemii, barometer_delegate, jarunik, dutch_pool, kolap, alessio, blues_for_alice, pieface, cryptology, zillion, toad, arky, goose, shamrock, private, arkpool, superskeuo, rasputin, firefly, arkship, ravelou, itsanametoo, rising_sun, kaos, geops, del, biz_classic, biz_private, dutchdelegate

In this case, biz_classic forged fine, but dutchdelegate did not. However, towards the end of the round, extracts from the log reveal the following:

[2020-02-12 13:40:41.779] DEBUG: Delegate del (03d9ed6e7f29daf12ef925d4ce5753aade23c8cfd52a0427240fb30ad6ec232fed) allowed to forge block 11,280,993
[2020-02-12 13:40:50.128] DEBUG: Delegate biz_classic (020431436cf94f3c6a6ba566fe9e42678db8486590c732ca6c3803a10a86f50b92) allowed to forge block 11,280,994
[2020-02-12 13:40:57.650] DEBUG: Delegate biz_private (02fa6902e91e127d6d3410f6abc271a79ae24029079caa0db5819757e3c1c1c5a4) allowed to forge block 11,280,995
[2020-02-12 13:41:13.319] DEBUG: Delegate arknet (0217ff1ec656f2354a899bde097bb3131a9730fe491bb87dedb96489120be9154f) allowed to forge block 11,280,996
[2020-02-12 13:41:13.319] INFO : Starting Round 221,197
[2020-02-12 13:41:13.320] DEBUG: Delegate dutchdelegate (0218b77efb312810c9a549e2cc658330fcc07f554d465673e08fa304fa59e67a0a) just missed a round.
[2020-02-12 13:41:13.433] DEBUG: Loaded 51 active delegates
[2020-02-12 13:41:13.435] INFO : Saving round 221,197
[2020-02-12 13:41:13.463] DEBUG: Delegate biz_classic (020431436cf94f3c6a6ba566fe9e42678db8486590c732ca6c3803a10a86f50b92) just missed a block.

As you can see, as soon as round 221,197 started, it fired the ForgerMissing event incorrectly stating that biz_classic had missed a block. It was, however, dutchdelegate that missed a block (hence arknet forged in its place). Although the log correctly showed that dutchdelegate missed a round, it incorrectly labelled biz_classic as missing the block when it should've been dutchdelegate.

Also for clarity, biz_classic was not the first delegate in line to forge in round 221,197; that was fun, which forged correctly. Indeed, the full round order for 221,197 was fun, barometer_delegate, kaos, bioly, arknet, goose, arkmoon, calidelegate, quarkpool, private, dutch_pool, doc, arkship, arkpool, ghostfaceuk, tibonos, blues_for_alice, rising_sun, dated, espresso, shamrock, toad, arkane, alessio, arky, civseed, jarunik, firefly, echo, del, zillion, cryptology, lemii, rasputin, drakeler, dutchdelegate, cactus1549, kolap, deadlock, thegoldenhorde, arkworld, geops, ravelou, superskeuo, pieface, itsanametoo, cams_yellow_jacket, thefoundry, biz_private, biz_classic, samuray.

This is important because it is firing false positive alerts for delegates that monitor that event in case their node is missing blocks, causing unnecessary panic and makes it an unreliable metric.

It seems that it is caused when the last delegate in a round misses a block, although I don't know why it decided it was biz_classic that missed the block, since biz_private came afterwards before dutchdelegate.

Expected Behavior

It should fire the ForgerMissing event for dutchdelegate at the end of round 221,196.

Current Behavior

It fired the ForgerMissing event for biz_classic instead at the end of round 221,196.

[ghost]

Thanks for opening this issue! A maintainer will review this in the next few days and explicitly select labels so you know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

[faustbrian]

#3507

[ghost]

This issue has been closed. If you wish to re-open it please provide additional information.