Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core-database): check for missed blocks before applying round #3507

Merged
merged 1 commit into from
Feb 17, 2020
Merged

fix(core-database): check for missed blocks before applying round #3507

merged 1 commit into from
Feb 17, 2020

Conversation

alessiodf
Copy link
Contributor

@alessiodf alessiodf commented Feb 16, 2020

Summary

Fixes #3491 by detecting missed blocks before applying the round, since applying the round will repopulate forgingDelegates with the order of the new round, but we need to check against the current (old) round to detect the correct delegate if the last delegate in a round misses its block. Otherwise it incorrectly fires for a different delegate in the new round.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ghost
Copy link

ghost commented Feb 16, 2020

Thanks for submitting this pull request! A maintainer will review this in the next few days and explicitly select labels so you know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@ghost
Copy link

ghost commented Feb 17, 2020

A collaborator has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.

Thank you for your contribution!

@faustbrian faustbrian merged commit 6d4c00a into ArkEcosystem:2.6 Feb 17, 2020
@ghost
Copy link

ghost commented Feb 17, 2020

Your pull request has been merged and marked as tier 4. It will earn you $20 USD.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants