Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core v3: log error handling on WS connection loss #3782

Closed
adrian69 opened this issue Jun 8, 2020 · 0 comments
Closed

Core v3: log error handling on WS connection loss #3782

adrian69 opened this issue Jun 8, 2020 · 0 comments

Comments

@adrian69
Copy link
Collaborator

adrian69 commented Jun 8, 2020

Expected Behavior

We should print something meaningful, saying we've lost connection 💡

Current Behavior

The error bellow is logged on each WS connection loss:

    at new NesError (/home/node/core/node_modules/@hapi/nes/lib/client.js:69:19)
    at reconnect (/home/node/core/node_modules/@hapi/nes/lib/client.js:203:26)
    at WebSocket.ws.onerror (/home/node/core/node_modules/@hapi/nes/lib/client.js:273:24)
    at WebSocket.onError (/home/node/core/node_modules/ws/lib/event-target.js:128:16)
    at WebSocket.emit (events.js:311:20)
    at ClientRequest.<anonymous> (/home/node/core/node_modules/ws/lib/websocket.js:568:15)
    at ClientRequest.emit (events.js:311:20)
    at Socket.socketErrorListener (_http_client.js:426:9)
    at Socket.emit (events.js:311:20)
    at emitErrorNT (internal/streams/destroy.js:92:8) {
  type: 'ws',
  isNes: true
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants