Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core-p2p): replace ws connection logging method #3791

Merged
merged 2 commits into from
Jun 13, 2020

Conversation

sebastijankuzner
Copy link
Contributor

Summary

Fix #3782.

Checklist

  • Tests
  • Ready to be merged

@ghost ghost added the Complexity: Low label Jun 11, 2020
@sebastijankuzner sebastijankuzner changed the title Chore/core p2p/log on lost connection fix(core-p2p): replace ws connection logging method Jun 11, 2020
@codecov
Copy link

codecov bot commented Jun 11, 2020

Codecov Report

Merging #3791 into develop will increase coverage by 6.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3791      +/-   ##
===========================================
+ Coverage    90.79%   96.86%   +6.07%     
===========================================
  Files          616      616              
  Lines        13611    13864     +253     
  Branches      1543     1672     +129     
===========================================
+ Hits         12358    13430    +1072     
- Misses         132      145      +13     
+ Partials      1121      289     -832     
Flag Coverage Δ
#functional 6.23% <0.00%> (-0.16%) ⬇️
#integration 10.02% <0.00%> (-0.14%) ⬇️
#unit 95.18% <100.00%> (+6.12%) ⬆️
Impacted Files Coverage Δ
packages/core-p2p/src/peer-connector.ts 100.00% <100.00%> (+8.00%) ⬆️
...ckages/core-snapshots/src/filesystem/filesystem.ts 72.22% <0.00%> (-27.78%) ⬇️
packages/core-webhooks/src/server/utils.ts 75.00% <0.00%> (-25.00%) ⬇️
packages/core-api/src/plugins/pagination/config.ts 75.00% <0.00%> (-25.00%) ⬇️
...ckages/core-manager/src/server/validators/token.ts 80.00% <0.00%> (-20.00%) ⬇️
...shots/src/workers/actions/restore-worker-action.ts 80.95% <0.00%> (-19.05%) ⬇️
packages/core-kernel/src/utils/ipc-handler.ts 81.81% <0.00%> (-18.19%) ⬇️
...ore-transactions/src/handlers/two/multi-payment.ts 81.63% <0.00%> (-16.33%) ⬇️
...ore-magistrate-transactions/src/handlers/entity.ts 68.29% <0.00%> (-14.64%) ⬇️
...test-framework/src/matchers/blockchain/dispatch.ts 85.71% <0.00%> (-14.29%) ⬇️
... and 312 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6df08b9...6f42894. Read the comment docs.

@faustbrian faustbrian merged commit 3525e86 into develop Jun 13, 2020
@ghost ghost deleted the chore/core-p2p/log-on-lost-connection branch June 13, 2020 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants