New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: core-utils #1077

Merged
merged 9 commits into from Oct 8, 2018

Conversation

Projects
None yet
3 participants
@faustbrian
Collaborator

faustbrian commented Oct 8, 2018

Proposed changes

Moves some commonly shared utilities into a package core-utils which can be re-used by other packages and reduces duplication at the same time.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works

@faustbrian faustbrian requested review from air1one, alexbarnsley and supaiku0 Oct 8, 2018

faustbrian added some commits Oct 8, 2018

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Oct 8, 2018

Codecov Report

Merging #1077 into develop will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1077      +/-   ##
===========================================
- Coverage    73.19%   73.16%   -0.03%     
===========================================
  Files          421      423       +2     
  Lines         6867     6871       +4     
  Branches       877      878       +1     
===========================================
+ Hits          5026     5027       +1     
- Misses        1642     1647       +5     
+ Partials       199      197       -2
Impacted Files Coverage Δ
packages/core-utils/lib/format-timestamp.js 100% <100%> (ø)
...ages/core-api/lib/versions/2/transformers/block.js 100% <100%> (ø) ⬆️
...ckages/core-database/lib/repositories/delegates.js 70.37% <100%> (ø) ⬆️
...s/core-api/lib/versions/2/transformers/delegate.js 85.71% <100%> (-1.79%) ⬇️
packages/core-utils/lib/index.js 100% <100%> (ø)
...ore-api/lib/versions/2/transformers/transaction.js 100% <100%> (ø) ⬆️
packages/core-utils/lib/delegate-calculator.js 100% <100%> (ø)
...s/core-api/lib/versions/1/transformers/delegate.js 100% <100%> (ø) ⬆️
.../versions/2/transformers/utils/format-timestamp.js 0% <0%> (-100%) ⬇️
...base/lib/repositories/utils/delegate-calculator.js 0% <0%> (-90%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86d20de...c8c234d. Read the comment docs.

codecov-io commented Oct 8, 2018

Codecov Report

Merging #1077 into develop will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1077      +/-   ##
===========================================
- Coverage    73.19%   73.16%   -0.03%     
===========================================
  Files          421      423       +2     
  Lines         6867     6871       +4     
  Branches       877      878       +1     
===========================================
+ Hits          5026     5027       +1     
- Misses        1642     1647       +5     
+ Partials       199      197       -2
Impacted Files Coverage Δ
packages/core-utils/lib/format-timestamp.js 100% <100%> (ø)
...ages/core-api/lib/versions/2/transformers/block.js 100% <100%> (ø) ⬆️
...ckages/core-database/lib/repositories/delegates.js 70.37% <100%> (ø) ⬆️
...s/core-api/lib/versions/2/transformers/delegate.js 85.71% <100%> (-1.79%) ⬇️
packages/core-utils/lib/index.js 100% <100%> (ø)
...ore-api/lib/versions/2/transformers/transaction.js 100% <100%> (ø) ⬆️
packages/core-utils/lib/delegate-calculator.js 100% <100%> (ø)
...s/core-api/lib/versions/1/transformers/delegate.js 100% <100%> (ø) ⬆️
.../versions/2/transformers/utils/format-timestamp.js 0% <0%> (-100%) ⬇️
...base/lib/repositories/utils/delegate-calculator.js 0% <0%> (-90%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86d20de...c8c234d. Read the comment docs.

faustbrian added some commits Oct 8, 2018

@faustbrian faustbrian merged commit 0e9743e into develop Oct 8, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@faustbrian faustbrian deleted the core-utils branch Oct 8, 2018

vasild added a commit that referenced this pull request Oct 8, 2018

Merge remote-tracking branch 'ArkEcosystem/core/develop' into feat/tr…
…ansaction-pool-mem

* ArkEcosystem/core/develop:
  feat: core-utils (#1077)
  feat: forged rewards and fees for delegate (v2 API) (#1076)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment