Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: require node 10 as minimum engine #1246

Merged
merged 2 commits into from Oct 30, 2018
Merged

chore: require node 10 as minimum engine #1246

merged 2 commits into from Oct 30, 2018

Conversation

faustbrian
Copy link
Contributor

Proposed changes

Follow up to #1245 as we use some features for snapshots that are only available from node 10 and afterwards.

Types of changes

  • Build (changes that affect the build system)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

@faustbrian faustbrian requested a review from spkjp October 30, 2018 11:40
@ghost ghost assigned faustbrian Oct 30, 2018
@ghost ghost added the review label Oct 30, 2018
@codecov-io
Copy link

codecov-io commented Oct 30, 2018

Codecov Report

Merging #1246 into develop will increase coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1246      +/-   ##
===========================================
+ Coverage    78.63%   78.78%   +0.14%     
===========================================
  Files          415      415              
  Lines         6966     6966              
  Branches       929      929              
===========================================
+ Hits          5478     5488      +10     
+ Misses        1316     1309       -7     
+ Partials       172      169       -3
Impacted Files Coverage Δ
...p2p/lib/server/versions/internal/handlers/utils.js 86.66% <0%> (+6.66%) ⬆️
packages/core-forger/lib/manager.js 81.52% <0%> (+9.78%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f85c541...6f6d541. Read the comment docs.

@faustbrian faustbrian merged commit 971e311 into develop Oct 30, 2018
@ghost ghost removed the review label Oct 30, 2018
@faustbrian faustbrian deleted the node-10 branch October 30, 2018 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants