Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use full Ark amounts in core-tester-cli instead #1260

Merged
merged 2 commits into from Nov 1, 2018
Merged

feat: use full Ark amounts in core-tester-cli instead #1260

merged 2 commits into from Nov 1, 2018

Conversation

paroxysm
Copy link
Contributor

@paroxysm paroxysm commented Nov 1, 2018

For more intuitive testing, specify full Ark amounts(as seen on explorer line items) as opposed to Arktoshi values in core-tester-cli commands. It's much more straight forward to type
node tester transfer -a 0.9 -recipient ... instead trying to convert 0.9 into Arktoshi.
It's also more in-line with the explorer as you see the same notation on there.

Proposed changes

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

@codecov-io
Copy link

codecov-io commented Nov 1, 2018

Codecov Report

Merging #1260 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1260   +/-   ##
========================================
  Coverage    78.85%   78.85%           
========================================
  Files          413      413           
  Lines         7003     7003           
  Branches       941      941           
========================================
  Hits          5522     5522           
  Misses        1309     1309           
  Partials       172      172

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcb4602...37a609a. Read the comment docs.

@ghost ghost assigned faustbrian Nov 1, 2018
@ghost ghost added the review label Nov 1, 2018
@faustbrian faustbrian merged commit 8fb0e35 into ArkEcosystem:develop Nov 1, 2018
@ghost ghost removed the review label Nov 1, 2018
@paroxysm paroxysm deleted the feat/use_full_ark_amounts_in_tester_cli branch November 2, 2018 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants