Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core-webhooks): include webhook ID in update schema #1295

Merged
merged 2 commits into from Nov 6, 2018

Conversation

thomas-neuman
Copy link
Contributor

Proposed changes

Include the required id parameter in schema for the PUT /webhooks/{id} method.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

No further documentation is included, and the existing unit tests suffice for the scope of this change.

@codecov-io
Copy link

Codecov Report

Merging #1295 into develop will increase coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1295      +/-   ##
===========================================
+ Coverage     74.5%   74.63%   +0.13%     
===========================================
  Files          422      422              
  Lines         7318     7318              
  Branches       990      990              
===========================================
+ Hits          5452     5462      +10     
+ Misses        1645     1638       -7     
+ Partials       221      218       -3
Impacted Files Coverage Δ
packages/core-webhooks/lib/server/schema.js 100% <ø> (ø) ⬆️
...p2p/lib/server/versions/internal/handlers/utils.js 86.66% <0%> (+6.66%) ⬆️
packages/core-forger/lib/manager.js 82.1% <0%> (+9.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 939398d...6b24451. Read the comment docs.

@faustbrian faustbrian merged commit f19f8e7 into ArkEcosystem:develop Nov 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants