Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: initial flow setup #1364

Merged
merged 2 commits into from Nov 11, 2018
Merged

chore: initial flow setup #1364

merged 2 commits into from Nov 11, 2018

Conversation

faustbrian
Copy link
Contributor

Proposed changes

Initial setup of https://flow.org to get the benefits of static type checking as we lately had some issues that would have shown up right away with it.

All the current errors will be fixed in subsequent PRs, this is just the setup.

Types of changes

  • Other

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

@ghost ghost assigned faustbrian Nov 11, 2018
@ghost ghost added the review label Nov 11, 2018
@codecov-io
Copy link

Codecov Report

Merging #1364 into develop will increase coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1364      +/-   ##
===========================================
+ Coverage     73.7%   73.83%   +0.13%     
===========================================
  Files          419      419              
  Lines         7431     7431              
  Branches      1008     1008              
===========================================
+ Hits          5477     5487      +10     
+ Misses        1720     1713       -7     
+ Partials       234      231       -3
Impacted Files Coverage Δ
...p2p/lib/server/versions/internal/handlers/utils.js 86.66% <0%> (+6.66%) ⬆️
packages/core-forger/lib/manager.js 79.59% <0%> (+9.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 035d090...8c19623. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants