New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unnecessary await #1559

Merged
merged 1 commit into from Dec 3, 2018

Conversation

Projects
None yet
3 participants
@vasild
Contributor

vasild commented Dec 3, 2018

transaction pool's flush() method is not async, no need to call it with
await.

Proposed changes

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Build (changes that affect the build system)
  • Docs (documentation only changes)
  • Test (adding missing tests or fixing existing tests)
  • Other... Please describe:

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
chore: remove unnecessary await
transaction pool's flush() method is not async, no need to call it with
await.

@wafflebot wafflebot bot added the review label Dec 3, 2018

@codecov-io

This comment has been minimized.

codecov-io commented Dec 3, 2018

Codecov Report

Merging #1559 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1559   +/-   ##
========================================
  Coverage    74.75%   74.75%           
========================================
  Files          439      439           
  Lines         7894     7894           
  Branches      1038     1038           
========================================
  Hits          5901     5901           
  Misses        1770     1770           
  Partials       223      223

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 935b1e1...a4f991d. Read the comment docs.

@faustbrian faustbrian merged commit 2a80a2f into develop Dec 3, 2018

4 checks passed

ci/circleci: depcheck-lint Your tests passed on CircleCI!
Details
ci/circleci: test-node10-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-2 Your tests passed on CircleCI!
Details

@faustbrian faustbrian deleted the remove-wait-from-pool-flush branch Dec 3, 2018

@wafflebot wafflebot bot removed the review label Dec 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment