refactor(core-p2p): replace the network update timeout with a period check #1738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
Codecov Report
@@ Coverage Diff @@
## develop #1738 +/- ##
===========================================
- Coverage 39.51% 39.48% -0.03%
===========================================
Files 353 353
Lines 7671 7673 +2
Branches 1079 1098 +19
===========================================
- Hits 3031 3030 -1
- Misses 4626 4629 +3
Partials 14 14
Continue to review full report at Codecov.
|
spkjp
approved these changes
Dec 15, 2018
spkjp
added a commit
that referenced
this pull request
Dec 17, 2018
…ocess queue on fork (#1732) * refactor: remove misleading log output * refactor: move block exception check * fix: reset queue at the beginning of fork recovery * refactor: drop process queue after disregarding unchained block * fix: update blocks from current round after recovery * fix: check if received block contains forged transactions * refactor: only fork when downloaded block cannot be chained with last accepted block * refactor: only check forged transactions if it is a chained block * test: fix * fix(core-p2p): call updateNetworkStatusIfNotEnoughPeers in the correct context (#1737) * refactor(core-p2p): replace the network update timeout with a period check (#1738) * refactor(core-p2p): replace the network update timeout with a period check * refactor(core-p2p): only sett the last network timeout if it is not set or expired * chore(core-p2p): remove pTimeout dependency * refactor: change name and make sure the next network update is scheduled * chore(package): update better-sqlite3 to version 5.2.0 (#1739) * test(core-utils): increase coverage (#1742) * test(core-debugger-cli): increase coverage (#1743) * chore: update @babel/core and @babel/preset-env (#1740) * chore(package): update @babel/core to version 7.2.2 * chore(package): update @babel/preset-env to version 7.2.0 * chore(package): update lockfile yarn.lock * chore: update yarn.lock * test(crypto): increase identity coverage (#1744) * test(crypto): increase handler coverage (#1745) * test(crypto): increase handler coverage (#1746) * test(crypto): increase multi signature/payment coverage (#1747) * docs: changelog and readme formatting (#1824) * refactor: rename resetQueue * fix: only care about missing blocks when process queue is empty * refactor: reword log message * refactor: move fork into function * fix: accept internal blocks even if in fork state * fix: dont show peer tracker after init * refactor: remove useless forked flag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
The whole logic around how the
updateNetworkStatusIfNotEnoughPeersmethod is called is rather odd so it is replaced with a period check instead.Types of changes
Checklist