New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core-tester-cli): replace commander.js with @oclif #2051

Merged
merged 10 commits into from Feb 2, 2019

Conversation

Projects
None yet
4 participants
@faustbrian
Copy link
Collaborator

faustbrian commented Feb 1, 2019

Proposed changes

Resolves #1934

Types of changes

  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

ArkEcosystemBot commented Feb 1, 2019

@supaiku0 - please review this in the next few days. Be sure to explicitly select labels so I know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

ArkEcosystemBot commented Feb 1, 2019

@supaiku0 The ci/circleci: test-node10-2 job is failing as of ca3cae8d446868ede6682f3308abb46b063d140b. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@faustbrian faustbrian requested a review from supaiku0 Feb 1, 2019

supaiku0 added some commits Feb 1, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Feb 2, 2019

Codecov Report

Merging #2051 into develop will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #2051   +/-   ##
=======================================
  Coverage     73.8%   73.8%           
=======================================
  Files          367     367           
  Lines         8258    8258           
  Branches      1209    1200    -9     
=======================================
  Hits          6095    6095           
- Misses        2129    2131    +2     
+ Partials        34      32    -2
Impacted Files Coverage Δ
packages/core/src/utils.ts 66.66% <ø> (ø) ⬆️
packages/core-api/src/server.ts 71.42% <100%> (ø) ⬆️
packages/core-test-utils/src/helpers/container.ts 0% <0%> (ø) ⬆️
packages/core-test-utils/src/generators/wallets.ts 14.28% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5bcfe9...63e6e9b. Read the comment docs.

@faustbrian faustbrian merged commit c2c99e6 into develop Feb 2, 2019

6 checks passed

ci/circleci: test-node10-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-2 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-2 Your tests passed on CircleCI!
Details

@ArkEcosystemBot ArkEcosystemBot deleted the refactor/oclif-tester branch Feb 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment