Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: do not run tests in prepublishOnly #2081

Merged
merged 2 commits into from Feb 11, 2019
Merged

chore: do not run tests in prepublishOnly #2081

merged 2 commits into from Feb 11, 2019

Conversation

faustbrian
Copy link
Contributor

Proposed changes

Do not run tests before publishing as PRs cannot be merged with failing tests.

Types of changes

  • Other

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

@ghost
Copy link

ghost commented Feb 11, 2019

@air1one @supaiku0 - please review this in the next few days. Be sure to explicitly select labels so I know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@ghost ghost requested review from air1one and spkjp February 11, 2019 14:37
@faustbrian faustbrian changed the base branch from master to develop February 11, 2019 14:38
@faustbrian faustbrian merged commit 67c8557 into develop Feb 11, 2019
@ghost ghost deleted the publish branch February 11, 2019 14:38
@ghost ghost removed the Status: Needs Review label Feb 11, 2019
@ghost
Copy link

ghost commented Feb 11, 2019

@faustbrian The ci/circleci: test-node11-2 job is failing as of 13e306c4454794c08830e6ae1a890b79b8ce2f46. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant