docs: fix broken references to plugin docs

.circleci/configTemplate.json

@@ -65,8 +65,8 @@
                 },
                 {
                     "run": {
-                        "name": "Test",
-                        "command": ""
+                        "name": "Unit tests",
+                        "command": "cd ~/core && yarn test:unit:coverage --coverageDirectory .coverage/unit/ --maxWorkers=2"
                     }
                 },
                 {
@@ -154,8 +154,8 @@
                 },
                 {
                     "run": {
-                        "name": "Test",
-                        "command": ""
+                        "name": "Unit tests",
+                        "command": "cd ~/core && yarn test:unit:coverage --coverageDirectory .coverage/unit/ --maxWorkers=2"
                     }
                 },
                 {
@@ -183,7 +183,7 @@
     "workflows": {
         "version": 2,
         "build_and_test": {
-            "jobs": []
+            "jobs": ["test-node10-0", "test-node11-0"]
         }
     }
 }

.circleci/generateConfig.js

@@ -11,48 +11,28 @@ function jason(value) {
 
 fs.readdir("./packages", (_, packages) => {
     // test split
-    const packagesSplit = chunk(packages.sort(), 10);
+    const packagesChunks = splitPackages(packages);
 
-    const resetSqlCommand = "cd ~/core/.circleci && ./rebuild-db.sh"
-
-    for (const [name, job] of Object.entries(config.jobs)) {
+    for (const [name, unitJob] of Object.entries(config.jobs)) {
         // save cache
-        const saveCacheStep = config.jobs[name].steps.find(step => typeof step === "object" && step.save_cache);
+        const saveCacheStep = unitJob.steps.find(step => typeof step === "object" && step.save_cache);
         saveCacheStep.save_cache.paths = packages
             .map(package => `./packages/${package}/node_modules`)
             .concat("./node_modules");
 
+
+        // copy base unit jobs (unit tests) to adapt for integration tests
         const jobs = [
-            config.jobs[name],
-            jason(config.jobs[name]),
-            jason(config.jobs[name]),
+            jason(unitJob),
+            jason(unitJob), 
         ];
 
         jobs.forEach((job, index) => {
             const testStepIndex = job.steps.findIndex(
-                step => typeof step === "object" && step.run && step.run.name === "Test",
+                step => typeof step === "object" && step.run && step.run.name === "Unit tests",
             );
 
-            const pkgs = packagesSplit[index].map(package => `./packages/${package}/`);
-
-            const steps = pkgs
-                .map(pkg => {
-                    const name = path.basename(pkg);
-
-                    return {
-                        run: {
-                            name,
-                            command: `${resetSqlCommand} && cd ~/core/packages/${name} && yarn test:coverage`,
-                        },
-                    };
-                })
-                .filter(pkg => {
-                    const {
-                        scripts
-                    } = require(path.resolve(__dirname, `../packages/${pkg.run.name}/package.json`));
-
-                    return Object.keys(scripts).includes("test:coverage");
-                });
+            const steps = getIntegrationSteps(packagesChunks[index]);
 
             const stepLog = job.steps[9];
             const stepLint = job.steps[10];
@@ -66,10 +46,41 @@ fs.readdir("./packages", (_, packages) => {
             job.steps.push(stepLint);
             job.steps.push(stepCoverage);
 
-            config.jobs[name.slice(0, -1) + index] = job;
-            config.workflows.build_and_test.jobs.push(name.slice(0, -1) + index);
+            config.jobs[name.slice(0, -1) + (index + 1)] = job;
+            config.workflows.build_and_test.jobs.push(name.slice(0, -1) + (index + 1));
         });
     }
 
     fs.writeFileSync(".circleci/config.yml", yaml.safeDump(config));
 });
+
+function splitPackages(packageNames) {
+    // split packages in two for integration tests
+    const integrationPackages = packageNames.sort()
+        .map(pkg => path.basename(pkg))
+        .filter(pkg => fs.existsSync(path.resolve(__dirname, `../__tests__/integration/${pkg}`)))
+
+    var indexToSplit = Math.floor(integrationPackages.length / 2);
+    return [
+        integrationPackages.slice(0, indexToSplit),
+        integrationPackages.slice(indexToSplit + 1)
+    ]
+}
+
+function getIntegrationSteps(packages) {
+    const resetSqlCommand = "cd ~/core/.circleci && ./rebuild-db.sh"
+
+    const steps = []
+    steps.push(...packages
+        .filter(pkg => fs.existsSync(path.resolve(__dirname, `../__tests__/integration/${pkg}`)))
+        .map(pkg => ({
+                run: {
+                    name: `${pkg} - integration`,
+                    command: `${resetSqlCommand} && cd ~/core && yarn test:coverage /integration/${pkg}/ --coverageDirectory .coverage/integration/${pkg}`,
+                },
+            })
+        )
+    );
+
+    return steps;
+}

.codecov.yml

@@ -2,14 +2,3 @@ ignore:
   - "packages/**/src/defaults.ts"
   - "packages/**/src/index.ts"
   - "packages/**/src/plugin.ts"
-  - "packages/core-error-tracker-bugsnag/**/*"
-  - "packages/core-error-tracker-sentry/**/*"
-  - "packages/core-graphql/**/*"
-  - "packages/core-http-utils/**/*"
-  - "packages/core-logger-winston/src/formatter.ts"
-  - "packages/core-snapshots-cli/**/*"
-  - "packages/core-test-utils/**/*"
-  - "packages/core-test-utils/src/fixtures/**/*"
-  - "packages/core-tester-cli/**/*"
-  - "packages/core-webhooks/src/database/migrations/**/*"
-  - "packages/core/**/*"

.github/PULL_REQUEST_TEMPLATE.md

@@ -1,35 +1,39 @@
-## Proposed changes
-<!--
-Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
--->
+<!-- Please don't delete this template and read our contribution guidelines at https://docs.ark.io/guidebook/contribution-guidelines/contributing.html -->
 
-## Types of changes
-<!--
-What types of changes does your code introduce?
-_Put an `x` in the boxes that apply and remove the rest of them: keep this PR as concise, but descriptive, as possible.._
--->
+## Summary
+
+<!-- Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. -->
+
+## What kind of change does this PR introduce?
+
+<!-- _Put an `x` in the boxes that apply. -->
+
+- [ ] Bugfix
+- [ ] New feature
+- [ ] Refactoring / Performance Improvements
+- [ ] Build-related changes
+- [ ] Documentation
+- [ ] Tests / Continuous Integration
+- [ ] Other, please describe:
 
-- [ ] Bugfix (non-breaking change which fixes an issue)
-- [ ] New feature (non-breaking change which adds functionality)
-- [ ] Refactoring (improve a current implementation without adding a new feature or fixing a bug)
-- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
-- [ ] Build (changes that affect the build system)
-- [ ] Docs (documentation only changes)
-- [ ] Test (adding missing tests or fixing existing tests)
-- [ ] Other... Please describe:
+## Does this PR introduce a breaking change?
+
+<!-- _Put an `x` in the boxes that apply. -->
+
+- [ ] Yes
+- [ ] No
 
 ## Checklist
-<!--
-_Put an `x` in the boxes that apply and remove this text and the rest of them. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
--->
+
+<!-- _Put an `x` in the boxes that apply. -->
 
 - [ ] I have read the [CONTRIBUTING](https://docs.ark.io/guidebook/contribution-guidelines/contributing.html) documentation
 - [ ] Lint and unit tests pass locally with my changes
 - [ ] I have added tests that prove my fix is effective or that my feature works
-- [ ] I have added necessary documentation (if appropriate)
-<!--
+- [ ] I have added necessary documentation _(if appropriate)_
 
-## Further comments
+## Other information
 
-If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...
+<!--
+If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc.
 -->

CHANGELOG.md

@@ -7,6 +7,46 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 
 ## [Unreleased]
 
+## [2.3.0] - YYYY-MM-DD
+
+### Breaking Changes
+
+-   Removed the `wallets` table from the database ([#2209])
+    -   **Core 2.0 has been fully reliant on in-memory wallets since the 2.0 release. This only removes the dumping of wallets into the database as it is wasted space and doesn't serve any purpose.**
+    -   **If you have applications that rely on the database you should migrate them as soon as possible to using the API as only that data is provided in real-time.**
+-   Replace SQLite3 with lowdb in `core-webhooks` ([#2124])
+    -   **This significantly reduces the size of the package and it's dependencies.**
+-   Replaced `core-logger-winston` with `core-logger-pino` ([#2134])
+    -   **This significantly improves performance of logging when it occurs a lot in situation like syncing.**
+-   Rewrote `core-tester-cli` from scratch ([#2133])
+-   Merged `core-debugger-cli` into `core-tester-cli` and deprecated it ([#2133])
+
+### Added
+
+-   Implement AIP29 ([#2122])
+-   Search delegates by their username in `core-api` ([#2143])
+-   Implemented the `ark reinstall` command in `core` ([#2192])
+-   Added the `--force` flag to the `ark update` command in `core` ([#2190])
+-   Added more parameters for delegate searches in `core-api` ([#2184])
+-   Add the `/v2/delegates/active` endpoint to `core-api` ([#2205])
+-   Added restart flags to the `ark update` command in `core` ([#2218])
+-   Added the `make:block` command to `core-tester-cli` to create blocks ([#2221])
+
+### Fixed
+
+-   Properly sort peers by their version ([#2229])
+
+### Changed
+
+-   Increased the vendor field length to 255 bytes ([#2159])
+-   Replaced `micromatch` with `nanomatch` to improve performance ([#2165])
+-   Replaced `axios` with `got` to resolve known timeout issues with `axios` ([#2203])
+-   Switch block id to full SHA256 ([#2156])
+
+### Removed
+
+-   Removed dead fast rebuild code that hasn't been used since 2.0 release ([#2210])
+
 ## [2.2.0] - 2019-03-11
 
 ### Added
@@ -330,14 +370,33 @@ Closed security vulnerabilities:
 [#2108]: https://github.com/ArkEcosystem/core/pull/2108
 [#2119]: https://github.com/ArkEcosystem/core/pull/2119
 [#2121]: https://github.com/ArkEcosystem/core/pull/2121
+[#2122]: https://github.com/ArkEcosystem/core/pull/2122
 [#2123]: https://github.com/ArkEcosystem/core/pull/2123
+[#2124]: https://github.com/ArkEcosystem/core/pull/2124
 [#2125]: https://github.com/ArkEcosystem/core/pull/2125
+[#2133]: https://github.com/ArkEcosystem/core/pull/2133
+[#2133]: https://github.com/ArkEcosystem/core/pull/2133
+[#2134]: https://github.com/ArkEcosystem/core/pull/2134
 [#2135]: https://github.com/ArkEcosystem/core/pull/2135
 [#2137]: https://github.com/ArkEcosystem/core/pull/2137
 [#2139]: https://github.com/ArkEcosystem/core/pull/2139
 [#2142]: https://github.com/ArkEcosystem/core/pull/2142
+[#2143]: https://github.com/ArkEcosystem/core/pull/2143
 [#2144]: https://github.com/ArkEcosystem/core/pull/2144
 [#2149]: https://github.com/ArkEcosystem/core/pull/2149
 [#2152]: https://github.com/ArkEcosystem/core/pull/2152
+[#2156]: https://github.com/ArkEcosystem/core/pull/2156
+[#2159]: https://github.com/ArkEcosystem/core/pull/2159
+[#2165]: https://github.com/ArkEcosystem/core/pull/2165
+[#2184]: https://github.com/ArkEcosystem/core/pull/2184
+[#2190]: https://github.com/ArkEcosystem/core/pull/2190
+[#2192]: https://github.com/ArkEcosystem/core/pull/2192
+[#2203]: https://github.com/ArkEcosystem/core/pull/2203
+[#2205]: https://github.com/ArkEcosystem/core/pull/2205
 [#2207]: https://github.com/ArkEcosystem/core/pull/2207
+[#2209]: https://github.com/ArkEcosystem/core/pull/2209
+[#2210]: https://github.com/ArkEcosystem/core/pull/2210
 [#2217]: https://github.com/ArkEcosystem/core/pull/2217
+[#2218]: https://github.com/ArkEcosystem/core/pull/2218
+[#2221]: https://github.com/ArkEcosystem/core/pull/2221
+[#2229]: https://github.com/ArkEcosystem/core/pull/2229

README.md

@@ -19,7 +19,7 @@ This repository contains all plugins that make up the Ark Core.
 
 ## API Documentation
 
--   API v1 : https://docs.ark.io/api/public/v1/
+-   API v1 : https://docs.ark.io/archive/api/public-v1/ (Deprecated)
 -   API v2 : https://docs.ark.io/api/public/v2/
 
 ## GitHub Development Bounty
@@ -51,7 +51,6 @@ This repository contains all plugins that make up the Ark Core.
 | [core-p2p](/packages/core-p2p)                                     | [![npm](https://badgen.now.sh/npm/v/@arkecosystem/core-p2p)](https://www.npmjs.com/package/@arkecosystem/core-p2p)                                     | P2P Communication                    |
 | [core-snapshots](/packages/core-snapshots)                         | [![npm](https://badgen.now.sh/npm/v/@arkecosystem/core-snapshots)](https://www.npmjs.com/package/@arkecosystem/core-snapshots)                         | Snapshot Manager                     |
 | [core-snapshots-cli](/packages/core-snapshots-cli)                 | [![npm](https://badgen.now.sh/npm/v/@arkecosystem/core-snapshots-cli)](https://www.npmjs.com/package/@arkecosystem/core-snapshots-cli)                 | Snapshot CLI                         |
-| [core-test-utils](/packages/core-test-utils)                       | [![npm](https://badgen.now.sh/npm/v/@arkecosystem/core-test-utils)](https://www.npmjs.com/package/@arkecosystem/core-test-utils)                       | Test Utilities _(development only)_  |
 | [core-tester-cli](/packages/core-tester-cli)                       | [![npm](https://badgen.now.sh/npm/v/@arkecosystem/core-tester-cli)](https://www.npmjs.com/package/@arkecosystem/core-tester-cli)                       | Tester CLi _(development only)_      |
 | [core-transaction-pool](/packages/core-transaction-pool)           | [![npm](https://badgen.now.sh/npm/v/@arkecosystem/core-transaction-pool)](https://www.npmjs.com/package/@arkecosystem/core-transaction-pool)           | Transaction Pool                     |
 | [core-utils](/packages/core-utils)                                 | [![npm](https://badgen.now.sh/npm/v/@arkecosystem/core-utils)](https://www.npmjs.com/package/@arkecosystem/core-utils)                                 | Utilities                            |

packages/core-api/__tests__/__support__/setup.ts → __tests__/integration/core-api/__support__/setup.ts

@@ -1,13 +1,13 @@
 import { app } from "@arkecosystem/core-container";
 import { Database } from "@arkecosystem/core-interfaces";
 import delay from "delay";
-import { registerWithContainer, setUpContainer } from "../../../core-test-utils/src/helpers/container";
-import { plugin } from "../../src/plugin";
+import { plugin } from "../../../../packages/core-api/src/plugin";
+import { registerWithContainer, setUpContainer } from "../../../utils/helpers/container";
 
-import { delegates } from "../../../core-test-utils/src/fixtures";
+import { delegates } from "../../../utils/fixtures";
 import { generateRound } from "./utils/generate-round";
 
-import { queries } from "../../../core-database-postgres/src/queries";
+import { sortBy } from "@arkecosystem/utils";
 
 const round = generateRound(delegates.map(delegate => delegate.publicKey), 1);
 
@@ -24,7 +24,6 @@ async function setUp() {
     await setUpContainer({
         exclude: [
             "@arkecosystem/core-webhooks",
-            "@arkecosystem/core-graphql",
             "@arkecosystem/core-forger",
             "@arkecosystem/core-json-rpc",
             "@arkecosystem/core-api",
@@ -33,8 +32,7 @@ async function setUp() {
 
     const databaseService = app.resolvePlugin<Database.IDatabaseService>("database");
     await databaseService.connection.roundsRepository.truncate();
-    await databaseService.buildWallets(1);
-    await databaseService.saveWallets(true);
+    await databaseService.buildWallets();
     await databaseService.saveRound(round);
 
     await registerWithContainer(plugin, options);
@@ -50,11 +48,12 @@ async function tearDown() {
 async function calculateRanks() {
     const databaseService = app.resolvePlugin<Database.IDatabaseService>("database");
 
-    const rows = await (databaseService.connection as any).query.manyOrNone(queries.spv.delegatesRanks);
+    const delegateWallets = Object.values(databaseService.walletManager.allByUsername()).sort(
+        (a: Database.IWallet, b: Database.IWallet) => b.voteBalance.comparedTo(a.voteBalance),
+    );
 
-    rows.forEach((delegate, i) => {
+    sortBy(delegateWallets, "publicKey").forEach((delegate, i) => {
         const wallet = databaseService.walletManager.findByPublicKey(delegate.publicKey);
-        wallet.missedBlocks = +delegate.missedBlocks;
         (wallet as any).rate = i + 1;
 
         databaseService.walletManager.reindex(wallet);

packages/core-api/__tests__/repositories/transactions.test.ts → __tests__/integration/core-api/repositories/transactions.test.ts

@@ -1,10 +1,10 @@
-import "@arkecosystem/core-test-utils";
 import "jest-extended";
+import "../../../utils";
 
 import { crypto } from "@arkecosystem/crypto";
-import genesisBlock from "../../../core-test-utils/src/config/testnet/genesisBlock.json";
 // noinspection TypeScriptPreferShortImport
-import { TransactionsRepository } from "../../dist/repositories/transactions";
+import { TransactionsRepository } from "../../../../packages/core-api/src/repositories/transactions";
+import genesisBlock from "../../../utils/config/testnet/genesisBlock.json";
 import { setUp, tearDown } from "../__support__/setup";
 
 let repository;

packages/core-api/__tests__/v1/handlers/accounts.test.ts → __tests__/integration/core-api/v1/handlers/accounts.test.ts

@@ -1,4 +1,4 @@
-import "@arkecosystem/core-test-utils";
+import "../../../../utils";
 import { setUp, tearDown } from "../../__support__/setup";
 import { utils } from "../utils";
 

packages/core-api/__tests__/v1/handlers/blocks.test.ts → __tests__/integration/core-api/v1/handlers/blocks.test.ts

@@ -1,6 +1,6 @@
 import { app } from "@arkecosystem/core-container";
-import "@arkecosystem/core-test-utils";
-import genesisBlock from "../../../../core-test-utils/src/config/testnet/genesisBlock.json";
+import "../../../../utils";
+import genesisBlock from "../../../../utils/config/testnet/genesisBlock.json";
 import { setUp, tearDown } from "../../__support__/setup";
 import { utils } from "../utils";
 

packages/core-api/__tests__/v1/handlers/delegates.test.ts → __tests__/integration/core-api/v1/handlers/delegates.test.ts

@@ -1,4 +1,4 @@
-import "@arkecosystem/core-test-utils";
+import "../../../../utils";
 import { setUp, tearDown } from "../../__support__/setup";
 import { utils } from "../utils";