Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix broken references to plugin docs #2263

Closed
wants to merge 85 commits into from
Closed

docs: fix broken references to plugin docs #2263

wants to merge 85 commits into from

Conversation

jamesbooker
Copy link
Contributor

Proposed changes

Updates various readme.md files to resolve #2262

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Build (changes that affect the build system)
  • Docs (documentation only changes)
  • Test (adding missing tests or fixing existing tests)
  • Other... Please describe:

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

paroxysm and others added 30 commits February 20, 2019 14:08
@paroxysm @faustbrian
refactor: move core-api repositories into core-database-* (#2107)
57374e6
@spkjp @faustbrian
feat: implement AIP29 (#2122)
187993d
@faustbrian
Merge branch 'develop' into 2.3
1c64f51
@faustbrian
refactor(core-webhooks): replace sqlite3 with lowdb (#2124)
cc10cf6
@spkjp @faustbrian
fix(core-elasticsearch): build failure (#2127)
fc69339
@paroxysm @faustbrian
test(core-database): add tests to blocks & transactions business repo…
6a914c2 
…sitories (#2147)
@spkjp
Merge remote-tracking branch 'origin/develop' into 2.3
e406317
@faustbrian
Merge pull request #2157 from supaiku0/merge-develop
528dc1e 
Merge branch 'develop' into 2.3
@spkjp @faustbrian
perf(crypto): integrate bcrypto (#2158)
fd70671
@faustbrian
feat(core-logger-pino): initial implementation (#2134)
be50e96
@dated @faustbrian
feat(core-api): search delegates by usernames (#2143)
e194ac6
@spkjp @faustbrian
feat(crypto): increase vendor field length to 255 bytes (#2159)
66b3a28
@faustbrian @spkjp
refactor: replace micromatch with nanomatch and remove heavy deps (#2165
1c47fa2 
)

* refactor: replace micromatch with the more lightweight nanomatch

* fix(core-http-utils): remove non-existent deps

* fix(core-vote-report): add vision dependency

* Update create.ts
@spkjp @faustbrian
refactor(crypto): benchmarks (#2167)
3449c6f
@faustbrian
chore: move core-graphql to the deprecated folder (#2169)
358c312
@air1one @faustbrian
test: initial restructure & split of unit and integration tests (#2172)
a823c32
@faustbrian
refactor: replace dayjs-ext with dato (#2168)
44b6ed9
@spkjp @faustbrian
refactor: peg block timestamp to slot (#2176)
379522b
@air1one @faustbrian
chore: circleci update coverage directory (#2177)
0875de6
@faustbrian
chore: remove extraneous jest presets and config (#2182)
eaf4fe1
@faustbrian
refactor(core-tester-cli): rewrite from scratch (#2133)
bdd07d3
@spkjp @faustbrian
refactor(crypto): de/serialization (#2175)
a986cb8
@spkjp @faustbrian
refactor: move transaction logic out of crypto (#2188)
317e86e
@faustbrian
feat(core-tester-cli): test the vendor field (#2189)
cf781a1
@faustbrian
feat(core-tester-cli): add the ability to send multiple waves (#2191)
8a95e95
@faustbrian
feat(core): add support for reinstalling the current version (#2192)
4e2c3f2
@faustbrian
feat(core): add support for forced updates (#2190)
5bfc691
@faustbrian
Merge branch 'develop' into 2.3
5ca3939
@faustbrian
style: apply prettier formatting
88ff072
@faustbrian
test(core-container): remove old test
f89ebe4
faustbrian and others added 6 commits March 18, 2019 14:39
@faustbrian
chore: remove packages from codecov ignore list (#2256)
7a1ccd6
@faustbrian
refactor: remove missed blocks and productivity (#2257)
0288158
@vasild @spkjp
fix(core-utils): handle NSect edge case (#2259)
d7f8351 
If the search range is narrowed too much then the condition
"if (low + this.nAry >= high) {" would catch it and return. But it could
happen that we still have neighboring elements and that condition is not
true.

Check whether the probe declared that the highest match is at some
height and if we have probed the next height - the fact that the next
height was not declared a match, implicitly means that it is not a
match. And if we have two neighboring heights, the lower one a match and
the higher one not, then we don't need to search further and have the
final result.
@spkjp @faustbrian
fix(core-blockchain): handle unhandled event (#2260)
ee4436a
@faustbrian
feat(core-logger-pino): set different log levels for console and file (…
66bd762 
…#2261)
@jamesbooker @faustbrian
Broken docs links fixed
46093c9 
Resolves #2262

Co-Authored-By: Brian Faust <faustbrian@users.noreply.github.com>
@ghost
Copy link

ghost commented Mar 19, 2019

Thanks for submitting this pull request! A maintainer will review this in the next few days and explicitly select labels so you know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@ghost ghost added the Complexity: Low label Mar 19, 2019
@ghost
Copy link

ghost commented Mar 19, 2019

Your pull request doesn't follow our contribution guidelines. Please review and correct it.

@faustbrian faustbrian self-requested a review March 19, 2019 10:38
faustbrian
faustbrian suggested changes Mar 19, 2019
View reviewed changes
Copy link
Contributor

@faustbrian faustbrian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase this to develop.

@ArkEcosystem ArkEcosystem deleted a comment Mar 19, 2019
@faustbrian faustbrian changed the title Broken docs links fixed docs: fix broken references to plugin docs Mar 19, 2019
@codecov-io
Copy link

Codecov Report

Merging #2263 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2263   +/-   ##
======================================
  Coverage    79.2%   79.2%           
======================================
  Files         331     331           
  Lines        7924    7924           
  Branches     1125    1085   -40     
======================================
  Hits         6276    6276           
  Misses       1616    1616           
  Partials       32      32

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f271747...46093c9. Read the comment docs.

@jamesbooker
Copy link
Contributor Author

Please rebase this to develop.

I am struggling to do this, as it appears it's reverting dependencies to older versions? do I 'accept incoming changes'?

@jamesbooker
Copy link
Contributor Author

Please rebase this to develop.

I am struggling to do this, as it appears it's reverting dependencies to older versions? do I 'accept incoming changes'?

OK I have rebased, accepted changes from the develop branch and re-commited

@ghost
Copy link

ghost commented Mar 19, 2019 •
edited by ghost

The ci/circleci: test-node11-2 job is failing as of 395e8c3fb502eec6e1f62d4858f86b5bfec5b99d. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@ghost
Copy link

ghost commented Mar 19, 2019

The ci/circleci: test-node10-2 job is failing as of 395e8c3fb502eec6e1f62d4858f86b5bfec5b99d. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@faustbrian
Copy link
Contributor

It looks like you merged instead of doing a rebase, might be easier to close the PR and resubmit it based on develop.

@jamesbooker
Copy link
Contributor Author

It looks like you merged instead of doing a rebase, might be easier to close the PR and resubmit it based on develop.

OK

@ghost
Copy link

ghost commented Mar 19, 2019

Your pull request has been closed, thank you for trying to solve an issue. If you think it was closed prematurely please provide additional information.

@ghost ghost mentioned this pull request Mar 24, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@faustbrian faustbrian faustbrian requested changes

@kristjank kristjank Awaiting requested review from kristjank

@spkjp spkjp Awaiting requested review from spkjp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs re-org broke some readme.md links in core
9 participants
@jamesbooker @codecov-io @faustbrian @paroxysm @spkjp @dated @air1one @vasild @luciorubeens