-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core-snapshots): asset import, include rounds table #2502
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2502 +/- ##
==========================================
- Coverage 66.07% 65.99% -0.09%
==========================================
Files 400 400
Lines 8614 8628 +14
Branches 436 395 -41
==========================================
+ Hits 5692 5694 +2
- Misses 2877 2890 +13
+ Partials 45 44 -1
Continue to review full report at Codecov.
|
The ci/circleci: test-node10-integration-2 job is failing as of fb3c21c78c4328c942df30e016ff45f15d705571. Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! |
Summary
Fixes assets that were incorrectly imported, because of
decamelizeKeys
. This PR also changes theSnapshotManager
to include the rounds table when taking a snapshot since thePeerVerifier
does not work properly without it. Theoretically we could regenerate the rounds table from the blocks and transactions table alone, but it takes approx. 1 hours for mainnet so this is not an option.This PR invalidates all existing snapshots.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Does this PR release a new version?
Checklist