Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core-snapshots): asset import, include rounds table #2502

Merged
merged 5 commits into from
Apr 30, 2019
Merged

fix(core-snapshots): asset import, include rounds table #2502

merged 5 commits into from
Apr 30, 2019

Conversation

spkjp
Copy link
Contributor

@spkjp spkjp commented Apr 29, 2019

Summary

Fixes assets that were incorrectly imported, because of decamelizeKeys. This PR also changes the SnapshotManager to include the rounds table when taking a snapshot since the PeerVerifier does not work properly without it. Theoretically we could regenerate the rounds table from the blocks and transactions table alone, but it takes approx. 1 hours for mainnet so this is not an option.

This PR invalidates all existing snapshots.

What kind of change does this PR introduce?

  • Bugfix
  • New feature
  • Refactoring / Performance Improvements
  • Build-related changes
  • Documentation
  • Tests / Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
    • All tests are passing
    • All benchmarks are passing without any major regressions
    • Sync from 0 works on mainnet
    • Sync from 0 works on devnet
    • Starting a new network and forging on it work
    • Explorer is fully functional
    • Wallets are fully functional
  • No

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@codecov-io
Copy link

Codecov Report

Merging #2502 into master will decrease coverage by 0.08%.
The diff coverage is 18.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2502      +/-   ##
==========================================
- Coverage   66.07%   65.99%   -0.09%     
==========================================
  Files         400      400              
  Lines        8614     8628      +14     
  Branches      436      395      -41     
==========================================
+ Hits         5692     5694       +2     
- Misses       2877     2890      +13     
+ Partials       45       44       -1
Impacted Files Coverage Δ
...kages/core-snapshots/src/transport/verification.ts 0% <0%> (ø) ⬆️
packages/core-snapshots/src/manager.ts 0% <0%> (ø) ⬆️
packages/core-snapshots/src/utils.ts 0% <0%> (ø) ⬆️
packages/core-snapshots/src/transport/codec.ts 83.72% <30%> (-16.28%) ⬇️
packages/core-logger-winston/src/formatter.ts 42.85% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b74ec6a...ffce08f. Read the comment docs.

.circleci/config.yml Outdated Show resolved Hide resolved
@ghost
Copy link

ghost commented Apr 29, 2019

The ci/circleci: test-node10-integration-2 job is failing as of fb3c21c78c4328c942df30e016ff45f15d705571. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@spkjp spkjp marked this pull request as ready for review April 29, 2019 22:04
@spkjp spkjp requested a review from kristjank as a code owner April 29, 2019 22:04
@faustbrian faustbrian merged commit bdf3be2 into ArkEcosystem:master Apr 30, 2019
@ghost ghost removed the Status: In Progress label Apr 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants