Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core-p2p): filter peers that are on the same IP subnet #2507

Merged
merged 2 commits into from
Apr 30, 2019

Conversation

air1one
Copy link
Contributor

@air1one air1one commented Apr 30, 2019

Summary

Resolves #2089.

This is a simple solution to #2089 but it might be enough, please review / comment if you feel something could be improved.

What kind of change does this PR introduce?

  • New feature

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • No

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works

@ghost
Copy link

ghost commented Apr 30, 2019

The ci/circleci: test-node11-e2e job is failing as of 98ca26a35e10be339767696673e75fe1ef85b733. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@faustbrian faustbrian changed the title feat(p2p): filter peers that are on the same IP subnet feat(core-p2p): filter peers that are on the same IP subnet Apr 30, 2019
@faustbrian faustbrian merged commit b9a54b3 into develop Apr 30, 2019
@ghost ghost deleted the feat/p2p-ip-filtering branch April 30, 2019 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants