Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core-blockchain): replay command #2526

Merged
merged 14 commits into from May 4, 2019

Conversation

Projects
None yet
4 participants
@supaiku0
Copy link
Contributor

commented May 2, 2019

Summary

Resolves #1986.

This PR adds a new command to replay blocks in-memory from the local database.

A replay can be started with the following command:
./bin/run chain:replay

or optionally a target height can be passed to only replay until a certain height e.g.
./bin/run chain:replay --targetHeight 100

What kind of change does this PR introduce?

  • Bugfix
  • New feature
  • Refactoring / Performance Improvements
  • Build-related changes
  • Documentation
  • Tests / Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
    • All tests are passing
    • All benchmarks are passing without any major regressions
    • Sync from 0 works on mainnet
    • Sync from 0 works on devnet
    • Starting a new network and forging on it work
    • Explorer is fully functional
    • Wallets are fully functional
  • No

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented May 2, 2019

The ci/circleci: test-node11-e2e job is failing as of cf6a2abfe327f5d7468ccdc24a8166df054a76e4. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented May 2, 2019

The ci/circleci: test-node11-unit job is failing as of bb6c0bc8c37674d32937204545284bc1dd7318ef. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@codecov-io

This comment has been minimized.

Copy link

commented May 2, 2019

Codecov Report

Merging #2526 into develop will decrease coverage by 0.72%.
The diff coverage is 4.08%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2526      +/-   ##
===========================================
- Coverage    67.86%   67.13%   -0.73%     
===========================================
  Files          394      399       +5     
  Lines         8664     8758      +94     
  Branches       450      413      -37     
===========================================
  Hits          5880     5880              
- Misses        2726     2821      +95     
+ Partials        58       57       -1
Impacted Files Coverage Δ
...es/core-blockchain/src/replay/replay-blockchain.ts 0% <0%> (ø)
packages/core/src/helpers/replay.ts 0% <0%> (ø)
packages/core/src/commands/chain/replay.ts 0% <0%> (ø)
...e-blockchain/src/replay/memory-database-service.ts 0% <0%> (ø)
packages/core-blockchain/src/replay/errors.ts 0% <0%> (ø)
packages/crypto/src/blocks/deserializer.ts 92.59% <100%> (ø) ⬆️
packages/core-blockchain/src/blockchain.ts 57.93% <75%> (-0.41%) ⬇️
packages/core-logger-winston/src/formatter.ts 41.66% <0%> (ø) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 728b2a9...5d2500c. Read the comment docs.

supaiku0 and others added some commits May 2, 2019

@faustbrian faustbrian merged commit af0a517 into ArkEcosystem:develop May 4, 2019

12 checks passed

ci/circleci: test-node10-benchmark Your tests passed on CircleCI!
Details
ci/circleci: test-node10-e2e Your tests passed on CircleCI!
Details
ci/circleci: test-node10-functional Your tests passed on CircleCI!
Details
ci/circleci: test-node10-integration-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-integration-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-unit Your tests passed on CircleCI!
Details
ci/circleci: test-node11-benchmark Your tests passed on CircleCI!
Details
ci/circleci: test-node11-e2e Your tests passed on CircleCI!
Details
ci/circleci: test-node11-functional Your tests passed on CircleCI!
Details
ci/circleci: test-node11-integration-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-integration-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-unit Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.