feat(core-blockchain): enforce transactions' nonce order from blockPr… #2873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasild
requested review from
air1one,
faustbrian,
kristjank and
spkjp
as code owners
ghost
added
spkjp
previously approved these changes
Aug 13, 2019
kristjank
previously approved these changes
Aug 14, 2019
spkjp
suggested changes
Aug 15, 2019
__tests__/unit/core-blockchain/processor/block-processor.test.ts
Outdated
Show resolved
Hide resolved
|
Your pull request needs some changes. Please wait for a comment from one of our developers for more information. |
vasild
force-pushed
the
enforce-nonce-in-block-validation
branch
from
45fef6d
to
4b07b8b
Compare
spkjp
approved these changes
Aug 16, 2019
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ocessor
A summary of what changes this PR introduces and why they were made.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Does this PR release a new version?
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
developbranch, not themasterbranchIf adding a new feature, the PR's description includes: